Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add version dimension to metrics event #8419

Merged
merged 2 commits into from
May 5, 2020
Merged

add version dimension to metrics event #8419

merged 2 commits into from
May 5, 2020

Conversation

jennypollack
Copy link
Contributor

closes #8026

@jennypollack jennypollack requested a review from danjm April 27, 2020 17:56
@jennypollack jennypollack requested a review from a team as a code owner April 27, 2020 17:56
danjm
danjm previously approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt previously approved these changes Apr 27, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt dismissed their stale review April 27, 2020 18:28

Tests failing

Gudahtt
Gudahtt reviewed Apr 27, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, the old integration tests are failing. That's too bad.

Perhaps getManifest can be mocked in these tests? 🤔

Edit: Or maybe getVersion would be easier to mock out.

@jennypollack jennypollack requested a review from kumavis as a code owner May 4, 2020 22:04
@rekmarks rekmarks force-pushed the metrics-version branch from ee3342c to 2dbbeae Compare May 4, 2020 22:04
@rekmarks rekmarks requested review from Gudahtt and danjm May 4, 2020 22:28
@rekmarks
Copy link
Member

rekmarks commented May 4, 2020

@Gudahtt I mocked getVersion in 2dbbeae

@metamaskbot
Copy link
Collaborator

Builds ready [2dbbeae]

@kumavis
Copy link
Member

kumavis commented May 5, 2020

are we submitting analytics events in test/CI ?

@rekmarks
Copy link
Member

rekmarks commented May 5, 2020

@kumavis I believe so, but they're differentiated in Matomo

@jennypollack jennypollack merged commit e00982a into develop May 5, 2020
@jennypollack jennypollack deleted the metrics-version branch May 5, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis kumavis approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add version to metrics events
6 participants
@jennypollack @rekmarks @metamaskbot @kumavis @Gudahtt @danjm