[RFC] fix(popup): popup window relative to last focused window

[brad-decker]

Fixes #7314

Cause of bug

• The popup window is triggered from the background chrome process for the extension which has no height, width, left or top position (actually all are 0)
• The original logic attempted to use these to compute a good position for the popup.
• The result is that on dual displays, the popup always opened in the top left most pixel of the leftmost display

Suggested resolution

• use the browser extension API to grab the latest focused window
• check the left and top values for that window
• ???

I have defaulted to opening the popup perfectly aligned with the top left most pixel of the last focused window. This could end up being wonky. I would love to get an idea of what the best-case scenario would be from the product team @jacobcantele and of course would love input from the engineers on the approach here.

[brad-decker]

[rachelcope]

I've always felt that the confirmation window appearing on the upper left corner is disorienting since all other MetaMask interactions appear in the upper right corner window (near the fox in the browser bar).

This decision (I believe) was made so it would be harder to fake a MetaMask popup. Does the left side position not have the same risks? Is there any other reason for the upper left popup location?

I'd propose instead that the MetaMask window always appear on the upper right corner. These UX principles apply here:

1. consistency and principle of least surprise - (https://en.wikipedia.org/wiki/Principle_of_least_astonishment)
   Users should be able to anticipate that the MetaMask window will consistently show up in the same location. This would minimize surprise to where it might appear on their screen and reduce the learning time to get familiar with the product.

2. proximity principle (https://www.nngroup.com/articles/closeness-of-actions-and-objects-gui/) - things that appear close together on the screen are seen as related. Having the MetaMask window appear near the fox extension icon will help users mentally connect the two.

Any thoughts on this? @brad-decker @jacobcantele @danfinlay @cjeria @omnat

** having the popup always appear on the window relative to last focus is obviously a huge improvement regardless!

[brad-decker]

upper left is just easiest with the information the API returns, we can use other info to get the width of the browser and move the popup to the top-right if that is the desired effect.

[brad-decker]

Moved to top right corner with latest push.

[Gudahtt]

Thanks, this looks like a great solution!

[Gudahtt]

LGTM!

[whymarrh]

I agree that this is a good solution. I had one question about it.

[whymarrh]

LGTM!