Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connected status indicator #8270

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Connected status indicator #8270

merged 6 commits into from
Apr 1, 2020

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Apr 1, 2020

This PR implements the following:

Add the connected status indicator to the home page of the popup UI (@danjm, Figma)

  • This indicator should be green if the site in the active tab is connected to the current account, yellow if the site is connected to a different account, grey if it's connected to no accounts.
  • It should be omitted in the fullscreen or notification home screen UI

Demo video: https://streamable.com/srbyo

@metamaskbot
Copy link
Collaborator

Builds ready [f8f4963]
Page Load Metrics (837 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint37129582010
domContentLoaded614102983511555
load616103183711555
domInteractive614102883511555

@danjm danjm force-pushed the connected-status-indicator branch from f8f4963 to decf103 Compare April 1, 2020 16:55
@danjm danjm marked this pull request as ready for review April 1, 2020 16:56
@metamaskbot
Copy link
Collaborator

Builds ready [decf103]
Page Load Metrics (584 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint34443831
domContentLoaded3366605829847
load3376615849847
domInteractive3356595829847

@danjm danjm mentioned this pull request Apr 1, 2020
Closed
18 tasks
@whymarrh whymarrh changed the base branch from home-tabs to develop April 1, 2020 17:49
@whymarrh whymarrh removed the request for review from rekmarks April 1, 2020 18:24
whymarrh
whymarrh approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this and it work. I removed stray logs in 4287c40 and added a few commits to tidy up some of the logic. 👍

I did revert the unrelated changes to the account options icon in the menu bar (457bd36), that can be its own pull request.

@metamaskbot
Copy link
Collaborator

Builds ready [0d7dce8]
Page Load Metrics (641 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint35514142
domContentLoaded34977563910349
load35177664110349
domInteractive34977563910349

Gudahtt
Gudahtt approved these changes Apr 1, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ui/app/components/app/connected-status-indicator/connected-status-indicator.component.js
render () {
return (
<div className={classnames('connected-status-indicator', {
invisible: getEnvironmentType() !== ENVIRONMENT_TYPE_POPUP,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd rather we not render this at all rather than do the extra work of rendering it invisibly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can update this in a separate PR

@whymarrh whymarrh merged commit 3f38451 into develop Apr 1, 2020
@whymarrh whymarrh deleted the connected-status-indicator branch April 1, 2020 18:45
@danjm danjm mentioned this pull request Apr 1, 2020
Merged
1 task
@whymarrh whymarrh mentioned this pull request Apr 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@jennypollack jennypollack Awaiting requested review from jennypollack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @metamaskbot @whymarrh @Gudahtt