Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token cell to show inline stale balance warning #8259

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Mar 31, 2020

The token cell how shows a warning inline for the case where the token balance failed to update. It displays a warning icon next to the balance, with a tooltip that contains the same contents as was shown on the token list previously.

This was roughly modelled after the "Wallet home (full-screen)" Figma design. It doesn't match exactly yet though of course, as that design includes moving the token list into a tab. The rest of the design will come in follow-up PRs.

The token cell how shows a warning inline for the case where the token
balance failed to update. It displays a warning icon next to the
balance, with a tooltip that contains the same contents as was shown on
the token list previously.
@Gudahtt Gudahtt force-pushed the update-display-of-stale-token-balance branch from 28f446a to b422f36 Compare March 31, 2020 03:47
@metamaskbot
Copy link
Collaborator

Builds ready [b422f36]
Page Load Metrics (608 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint338545147
domContentLoaded3647496078541
load3657516088440
domInteractive3637496068541

@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 31, 2020

Screenshots:

Old design:
old-stale-balances

New design:
new_stale

New design with tooltip:
stale_with_tooltip

@whymarrh
Copy link
Contributor

The token cell how shows a warning inline for the case where the token balance failed to update.

Is this "where any token balance failed to update"? Is this a list-global error rendered alongside each token balance?

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me

@Gudahtt
Copy link
Member Author

Gudahtt commented Mar 31, 2020

Is this "where any token balance failed to update"? Is this a list-global error rendered alongside each token balance?

Yes, that is correct. The token tracker doesn't currently distinguish which token failed when a failure does occur. That would be nice though. It's something we should consider in future API changes to the token tracker.

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit a554353 into develop Mar 31, 2020
@Gudahtt Gudahtt deleted the update-display-of-stale-token-balance branch March 31, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants