Convert Connected Sites page to modal #8254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the existing _Connected Sites_ section to a modal using the `Popover` component. This will serve as a base for the new modal design.
whymarrh
force-pushed
the
connected-sites-modal
branch
from
2f775af to
61d0127
Compare
whymarrh
commented
Mar 30, 2020
test/e2e/permissions.spec.js
Outdated
| @@ -163,6 +163,7 @@ describe('MetaMask', function () { | |||
| await driver.switchToWindow(extension) | |||
|
|
|||
| await driver.clickElement(By.xpath(`//button[contains(text(), 'Disconnect All')]`)) | |||
| await driver.clickElement(By.css('.popover-bg')) | |||
There was a problem hiding this comment.
The confirmation modal is the old-style modal and is thus behind the popover. This is a workaround pending the forthcoming redesign.
whymarrh
force-pushed
the
connected-sites-modal
branch
from
61d0127 to
256ad92
Compare
whymarrh
commented
Mar 30, 2020
| @@ -163,6 +163,7 @@ describe('MetaMask', function () { | |||
| await driver.switchToWindow(extension) | |||
|
|
|||
| await driver.clickElement(By.xpath(`//button[contains(text(), 'Disconnect All')]`)) | |||
| await driver.clickElement(By.css('.popover-header__close')) | |||
There was a problem hiding this comment.
The confirmation modal is the old-style modal and is thus behind the popover. This is a workaround pending the forthcoming redesign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8242 and #8253 was the preparation work.
This PR migrates the existing Connected Sites page to a modal, serving as the base for the new modal designs (in a forthcoming PR). This leaves the routing intact, i.e. the
#connected-sitesroute still exists & works, but moves the route into theHomecomponent so that the home screen is the backdrop.Screenshots: