Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline the source text not the binary encoding for inpage script #8053

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Inline the source text not the binary encoding for inpage script #8053

merged 1 commit into from
Feb 14, 2020

Conversation

danfinlay
Copy link
Contributor

@danfinlay danfinlay commented Feb 14, 2020 •
edited by whymarrh
Loading

This PR updates the way we're inlining the inpage script into the contentscript to no longer write it as a base64 encoded string. The inpage script is now inlined as utf-8.

This should address the Chrome Web Store's policies against "obsfucation".

@whymarrh
Copy link
Contributor

whymarrh commented Feb 14, 2020 •
edited
Loading

Refs #6875

@whymarrh
Copy link
Contributor

Looking at the diff, I can confirm that this does remove the "obsfucated" inline string:

Before vs. after:

@whymarrh whymarrh requested review from Gudahtt and whymarrh February 14, 2020 19:13
Gudahtt
Gudahtt approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [0eed6f4]
Page Load Metrics (681 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint37122552311
domContentLoaded3787936798842
load3807956818842
domInteractive3787936798842

@Gudahtt Gudahtt merged commit cfcccd2 into develop Feb 14, 2020
@Gudahtt Gudahtt deleted the AvoidObfuscation branch February 14, 2020 19:27
Gudahtt pushed a commit that referenced this pull request Feb 14, 2020
@danfinlay @Gudahtt
Inline the source text not the binary encoding for inpage script (#8053)
39d944f
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 17, 2020
@danfinlay @yqrashawn
Inline the source text not the binary encoding for inpage script (Met…
8991a2c 
…aMask#8053)
@srirambv srirambv mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danfinlay @whymarrh @metamaskbot @Gudahtt