Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using contact names in place of tx address when applicable #7971

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Feb 1, 2020

Fixes: #7967

I used another address of mine as a contact and vitalik.eth for the other

Screen Shot 2020-02-01 at 3 40 53 PM

Screen Shot 2020-02-01 at 3 41 51 PM

Screen Shot 2020-02-01 at 3 41 58 PM

Screen Shot 2020-02-01 at 3 42 35 PM

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ryanml!

@whymarrh whymarrh merged commit 3bbbe13 into MetaMask:develop Feb 11, 2020
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 14, 2020
@ryanml ryanml deleted the contacts-tx branch February 22, 2020 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address book names should be used in tx history
2 participants