Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page navigation to e2e web driver #7867

Merged
merged 1 commit into from
Jan 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/webdriver/chrome.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class ChromeDriver {

return {
driver,
extensionUrl: `chrome-extension://${extensionId}/home.html`,
extensionUrl: `chrome-extension://${extensionId}`,
}
}

Expand Down
15 changes: 14 additions & 1 deletion test/e2e/webdriver/driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,10 @@ class Driver {
* @param {string} browser - The type of browser this driver is controlling
* @param {number} timeout
*/
constructor (driver, browser, timeout = 10000) {
constructor (driver, browser, extensionUrl, timeout = 10000) {
this.driver = driver
this.browser = browser
this.extensionUrl = extensionUrl
this.timeout = timeout
}

Expand Down Expand Up @@ -84,6 +85,12 @@ class Driver {
assert.ok(!dataTab, 'Found element that should not be present')
}

// Navigation

async navigate (page = Driver.PAGES.HOME) {
return await this.driver.get(`${this.extensionUrl}/${page}.html`)
}

// Window management

async openNewPage (url) {
Expand Down Expand Up @@ -173,4 +180,10 @@ class Driver {
}
}

Driver.PAGES = {
HOME: 'home',
NOTIFICATION: 'notification',
POPUP: 'popup',
}

module.exports = Driver
2 changes: 1 addition & 1 deletion test/e2e/webdriver/firefox.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class FirefoxDriver {
return {
driver,
extensionId,
extensionUrl: `moz-extension://${internalExtensionId}/home.html`,
extensionUrl: `moz-extension://${internalExtensionId}`,
}
}

Expand Down
6 changes: 2 additions & 4 deletions test/e2e/webdriver/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,12 @@ async function buildWebDriver ({ responsive, port } = {}) {

const { driver: seleniumDriver, extensionId, extensionUrl } = await buildBrowserWebDriver(browser, { extensionPath, responsive, port })
setupFetchMocking(seleniumDriver)
await seleniumDriver.get(extensionUrl)

const driver = new Driver(seleniumDriver, browser)
const driver = new Driver(seleniumDriver, browser, extensionUrl)
await driver.navigate()

return {
driver,
extensionId,
extensionUrl,
}
}

Expand Down