Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to account search functionality #7637

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Updates to account search functionality #7637

merged 1 commit into from
Dec 4, 2019

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Dec 4, 2019

Refs #7261

This PR updates the account search functionality introduced in #7261, with the following:

  1. Style fixes for consistency (pending Enable no-confusing-arrow rule for ESLint #7573 and Enable object-curly-spacing rule for ESLint #7591)
  2. Removed usage of withProp since that can be part of the existing mapStateToProps logic

Gudahtt
Gudahtt approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@whymarrh whymarrh merged commit 03f53df into MetaMask:develop Dec 4, 2019
@whymarrh whymarrh deleted the search-accounts-updates branch December 4, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rickycodes rickycodes Awaiting requested review from rickycodes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @Gudahtt