Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transactions/pending - buffer 3 blocks before dropping a tx #7483

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

frankiebee
Copy link
Contributor

woops miss spelled the branch just how you like it @tmashuang

fixes #7370

seems we might have stubbled across some out of sync nodes the average for out of sync nodes is 1 to 2 so this should buffer for that

@metamaskbot
Copy link
Collaborator

Builds ready [d1c4a3d]

@frankiebee frankiebee force-pushed the i#7370-fasly-dropped-txs branch from d1c4a3d to 95037ee Compare December 3, 2019 21:02
@frankiebee frankiebee force-pushed the i#7370-fasly-dropped-txs branch from 95037ee to 2682b07 Compare December 3, 2019 21:03
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@metamaskbot
Copy link
Collaborator

Builds ready [2682b07]

@frankiebee frankiebee merged commit 71a89df into develop Dec 5, 2019
@frankiebee frankiebee deleted the i#7370-fasly-dropped-txs branch December 5, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction incorrectly reported as "dropped"
3 participants