-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show transaction fee units on approve screen #7468
Conversation
ui/app/pages/confirm-approve/confirm-approve-content/confirm-approve-content.component.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5217dd9
to
1b3f194
Compare
Builds ready [1b3f194]
|
This should be ready to review again. I had to update one test. This is just a temporary solution - it's still lacking in a few ways:
But in the interest of getting this out there sooner, I think we should go with this for now, and at some point refactor the |
The units for the amounts shown on the approve screen in the transaction fee section were missing. It appears that they were present in an early version of the approve screen (#7271) but they got lost somewhere along the way.
1b3f194
to
67a149d
Compare
Builds ready [67a149d]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is a good quick fix
The units for the amounts shown on the approve screen in the transaction fee section were missing. It appears that they were present in an early version of the approve screen (#7271) but they got lost somewhere along the way.
Before:
After: