Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show transaction fee units on approve screen #7468

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 18, 2019

The units for the amounts shown on the approve screen in the transaction fee section were missing. It appears that they were present in an early version of the approve screen (#7271) but they got lost somewhere along the way.

Before:
migrate

After:
after_fee

whymarrh
whymarrh previously approved these changes Nov 18, 2019
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danjm
danjm previously approved these changes Nov 19, 2019
@Gudahtt Gudahtt dismissed stale reviews from danjm and whymarrh via 1b3f194 November 19, 2019 02:12
@Gudahtt Gudahtt force-pushed the add-approve-screen-transaction-fee-units branch from 5217dd9 to 1b3f194 Compare November 19, 2019 02:12
@metamaskbot
Copy link
Collaborator

Builds ready [1b3f194]

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 19, 2019

This should be ready to review again. I had to update one test.

This is just a temporary solution - it's still lacking in a few ways:

  • We should be using metamask.nativeCurrency instead of hard-coding ETH
  • We should be displaying either the fiat or native currency based upon the "Primary Currency" config setting
  • We should be omitting the fiat currency on test networks if the user has that setting enabled

But in the interest of getting this out there sooner, I think we should go with this for now, and at some point refactor the CurrencyDisplay component to be a bit easier to use for cases like this. Then ideally we'd use the CurrencyDisplay component here and it'd take care of those details for us.

The units for the amounts shown on the approve screen in the
transaction fee section were missing. It appears that they were present
in an early version of the approve screen (#7271) but they got lost
somewhere along the way.
@Gudahtt Gudahtt force-pushed the add-approve-screen-transaction-fee-units branch from 1b3f194 to 67a149d Compare November 19, 2019 04:56
@metamaskbot
Copy link
Collaborator

Builds ready [67a149d]

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this is a good quick fix

@Gudahtt Gudahtt merged commit 5c356a4 into develop Nov 19, 2019
@whymarrh whymarrh deleted the add-approve-screen-transaction-fee-units branch November 19, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants