I#6704 eth_getTransactionByHash will now check metamask's local history for pending transactions #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
along with a new middleware this also adds tests for the already existing one for getTransactionCount with block reference pending 😅 |
…ecks pending tx's for a response value
frankiebee
force-pushed
the
i#6704-pending-txs
branch
from
5673699 to
35839a7
Compare
Builds ready [353d32e]
|
frankiebee
changed the title
tmashuang
previously approved these changes
Oct 30, 2019
Gudahtt
reviewed
Oct 30, 2019
tmashuang
approved these changes
Oct 30, 2019
Builds ready [bc5f76d]
|
Gudahtt
approved these changes
Oct 30, 2019
tmashuang
pushed a commit
that referenced
this pull request
Nov 4, 2019
…ry for pending transactions (#7327) * tests - create tests for pending middlewares * transactions - add r,s,v values to the txMeta to match the JSON rpc response * network - add new middleware for eth_getTransactionByHash that the checks pending tx's for a response value * transactions/pending - use getTransactionReceipt for checking if tx is in a block * meta - file rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6704