Move signTypedData signing out to keyrings #7304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the logic of signing and improves security: - Private keys are never moved to the base controller. - Hardware wallets are abstracted in the same way as local keys. This also paves the way for allowing even more modular accounts, provided by plugins: MetaMask/metamask-snaps-beta#63 Fixes #7075.
7 tasks
Builds ready [25076da]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the logic of signing and improves security, and makes the
signTypedDataimplementation more consistent with the other signing methods:This also paves the way for allowing even more modular accounts,
provided by plugins:
MetaMask/metamask-snaps-beta#63
Fixes #7075.
I've run QA against the signature test site.
After this is merged:
developinto theLoginPerSitebranchLoginPerSitebranch into the latest plugin-beta branchsignTypedDatamethods through this new method onAddIdentityApibranch.