Prevent Logout Timer that's longer than a week. #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [9c0ab5b]
|
Gudahtt
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Thanks, looks good!
It looks like the root cause is that setTimeout doesn't support timeouts of over 2,147,483,647 ms (about 24.8 days). So while we could increase the max time somewhat, this does kinda address the root cause. Though preventing this in the background might be worthwhile as well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7231. Prevents the logout timer from being set longer than a week. This doesn't really fix the root cause of why the app logs out immediately and prevents login when setting an arbitrary large logout timer.