Prevent invalid inline speedup #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
i6844-prevent-invalid-inline-speedup
branch
3 times, most recently
from
4aefd33 to
65165ca
Compare
whymarrh
suggested changes
Sep 9, 2019
|
Yeah that rename doesn't really make sense anymore - I'll remove that commit. I had done that originally because that prop was used for cancellation as well in an earlier version of this branch. That isn't the case anymore though. |
Speeding up anything but the pending transaction with the lowest nonce is ineffectual, as the transaction with the lowest nonce blocks the others from completing first. The inline speed-up button in the transaction activity log has been removed for these invalid cases. The button will show up in the activity log for the pending transaction with the lowest nonce, but not for the others. Closes MetaMask#6844
Gudahtt
force-pushed
the
i6844-prevent-invalid-inline-speedup
branch
from
65165ca to
54fef0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeding up anything but the pending transaction with the lowest nonce is ineffectual, as the transaction with the lowest nonce blocks the others from completing first. The inline speed-up button in the transaction activity log has been removed for these invalid cases.
The button will show up in the activity log for the pending transaction with the lowest nonce, but not for the others.
Screenshots:
This shows two pending transactions, both cancelled. Only the oldest transaction (the one on top) shows the inline "Speed up this cancellation" button.
This screenshot shows the inline "Speed up this transaction" button. This is just to show that it still works - it's essentially unchanged, as this inline button only shows up after the top-level "Speed Up" button is used, and that initial speed-up isn't possible on any but the oldest pending transaction.
Closes #6844