Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Auto add needs-triage label on bug open #30512

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

desi
Copy link
Contributor

@desi desi commented Feb 21, 2025

Description

We use the stale bot in order to make sure we close out issues which have been open and waiting on additional information from reporters for too long. However, sometimes this can be the case for issues that we just haven't had an opportunity to follow back up on. We feel a couple of process improvements can make this better.

Open in GitHub Codespaces

Related issues

Partially fixes: https://github.com/MetaMask/MetaMask-planning/issues/4219

Related to:
https://github.com/MetaMask/github-tools/pull/41/files

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 21, 2025
Copy link
Contributor

@gauthierpetetin gauthierpetetin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We'll have to do the same changes on the Mobile repo to maintain parity.

@metamaskbot
Copy link
Collaborator

Builds ready [2bc7fef]
Page Load Metrics (1812 ± 81 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16172296181318187
domContentLoaded16062185177716680
load16212207181216981
domInteractive208437157
backgroundConnect10106392411
firstReactRender156023126
getState570202110
initialActions01000
loadScripts11431699130715273
setupStore874242110
uiStartup18892522206917082
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@desi desi marked this pull request as ready for review February 25, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants