Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cleanup snap-account-signature e2e tests. Add permittedChains scenario to wallet_revokePermissions e2e test #29761

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jan 16, 2025

Description

  • Fix incorrect snap-account-signature e2e test fixtures / starting state (accounts permissioned before they exist in the wallet)
  • Add endowment:permitted-chains scenario to wallet_revokePermissions e2e test

Open in GitHub Codespaces

Related issues

See: #27847

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jiexi jiexi changed the title Jl/cleanup fix e2e tests test: Cleanup snap-account-signature e2e tests. Add permittedChains scenario to wallet_revokePermissions e2e test Jan 16, 2025
@jiexi jiexi marked this pull request as ready for review January 16, 2025 18:03
adonesky1
adonesky1 previously approved these changes Jan 16, 2025
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [bf507bc]
Page Load Metrics (1720 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint32522801630358172
domContentLoaded140822571698208100
load143023321720214103
domInteractive278448199
backgroundConnect677222010
firstReactRender1686412612
getState45012136
initialActions01000
loadScripts9911782124817483
setupStore668182210
uiStartup161826881949249120
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 499 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt previously approved these changes Jan 16, 2025
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiexi jiexi dismissed stale reviews from Gudahtt and adonesky1 via 758165d January 16, 2025 18:49
@metamaskbot
Copy link
Collaborator

Builds ready [b199269]
Page Load Metrics (1750 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14982226176218991
domContentLoaded14892177171918087
load14992193175018287
domInteractive23110482311
backgroundConnect778332110
firstReactRender1597533216
getState45419178
initialActions01000
loadScripts10651595127315173
setupStore67413178
uiStartup168224932119260125
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 499 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [3aaa6ca]
Page Load Metrics (1546 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23818431485301144
domContentLoaded1379170115207737
load1396174415469043
domInteractive227737188
backgroundConnect56121199
firstReactRender15102463316
getState484152210
initialActions01000
loadScripts919130811048039
setupStore592152512
uiStartup159524251879225108
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 499 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: -372 Bytes (-0.00%)

@Gudahtt Gudahtt added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit a6a91d5 Jan 16, 2025
72 checks passed
@Gudahtt Gudahtt deleted the jl/cleanup-fix-e2e-tests branch January 16, 2025 22:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-wallet-api-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants