Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace portfolio links to bridge with native bridge exp #29175

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Dec 12, 2024

Description

Open in GitHub Codespaces

This PR replaces a link in Swaps to the Portfolio Bridge with a link to the native Bridge experience.

Related issues

Fixes:

Manual testing steps

  1. Go to Swaps
  2. Click on the Bridge link
  3. Get directed to native Bridge exp

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-12.at.5.59.26.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@infiniteflower infiniteflower marked this pull request as ready for review December 12, 2024 23:06
@infiniteflower infiniteflower requested a review from a team as a code owner December 12, 2024 23:06
@metamaskbot
Copy link
Collaborator

Builds ready [9c7764d]
Page Load Metrics (1637 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1484183816398842
domContentLoaded1462181516149043
load1488182716378842
domInteractive276637126
backgroundConnect991292412
firstReactRender16101502814
getState595212512
initialActions01000
loadScripts1071138711947737
setupStore784212713
uiStartup17272400198920598
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -332 Bytes (-0.00%)
  • common: 71 Bytes (0.00%)

@infiniteflower infiniteflower added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit bb1c77e Dec 13, 2024
88 checks passed
@infiniteflower infiniteflower deleted the mb1595-xchain-portfolio-links-to-native-exp branch December 13, 2024 17:02
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
@metamaskbot metamaskbot added the release-12.11.0 Issue or pull request that will be included in release 12.11.0 label Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.11.0 Issue or pull request that will be included in release 12.11.0 team-bridge team-swaps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants