fix: `Bridge{,Status}Controller` state types and restricted-path imports #28971

MajorLift · 2024-12-05T19:08:15Z

Motivation

ControllerState types should represent the entire state at root level that is passed to BaseController and RestrictedMessengerController.

The current set of types for Bridge{,Status}Controller state have issues:

There is no dedicated type that represents the controller state.
- This is inconvenient for typing e.g. selectors.
- This presents an unexpected API for downstream consumers which could lead to silent failures.
The messenger types for the getState action, stateChange` event, and other messages that reference the controller's state are incorrect.

For more information on writing controllers, see:

https://github.com/MetaMask/core/blob/main/docs/writing-controllers.md

Description

Renames:

BridgeControllerState type to BridgeState
BridgeStatusControllerState type to BridgeStatusState.
DEFAULT_BRIDGE_CONTROLLER_STATE constant to DEFAULT_BRIDGE_STATE.
DEFAULT_BRIDGE_STATUS_CONTROLLER_STATE constant to DEFAULT_BRIDGE_STATUS_STATE.
BridgeState Redux slice type to BridgeSlice.

Defines new BridgeControllerState, BridgeStatusControllerState types and DEFAULT_BRIDGE_CONTROLLER_STATE, DEFAULT_BRIDGE_STATUS_CONTROLLER_STATE constants that represent the corresponding controllers' state at root level.

Moves Bridge{,Status}Controller types and constants from app/scripts/{controllers,shared}, ui/pages/bridge to shared/types/bridge, resolving restricted-path imports and circular dependencies.

Note

See PR comments for a walkthrough of the changes.

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-05T19:08:28Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-12-05T20:05:06Z

Builds ready [3a3754b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1940 ± 61 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1734	2221	1945	126	61
		domContentLoaded	1662	2185	1911	129	62
		load	1730	2206	1940	127	61
		domInteractive	26	65	37	12	6
		backgroundConnect	7	66	28	20	10
		firstReactRender	15	111	28	24	12
		getState	79	355	156	67	32
		initialActions	0	0	0	0	0
		loadScripts	1262	1719	1465	118	57
		setupStore	7	61	12	12	6
		uiStartup	1962	2980	2298	240	115

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -20 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 75 Bytes (0.00%)

metamaskbot · 2024-12-10T15:09:00Z

Builds ready [f9e9539]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1874 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	542	2154	1819	318	153
		domContentLoaded	1632	2139	1837	117	56
		load	1660	2156	1874	120	58
		domInteractive	26	104	37	17	8
		backgroundConnect	11	87	42	21	10
		firstReactRender	17	98	34	28	14
		getState	82	313	165	81	39
		initialActions	0	1	0	0	0
		loadScripts	1239	1741	1443	112	54
		setupStore	6	80	12	16	8
		uiStartup	1946	2669	2285	242	116

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -20 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 75 Bytes (0.00%)

MajorLift

Walkthrough for reviewers:

MajorLift · 2024-12-11T22:48:26Z

shared/types/bridge.ts

+export type BridgeControllerState = {
+  bridgeState: BridgeState;
+};
+
+export type BridgeState = {
+  bridgeFeatureFlags: BridgeFeatureFlags;
+  srcTokens: Record<string, SwapsTokenObject>;
+  srcTopAssets: { address: string }[];
+  destTokens: Record<string, SwapsTokenObject>;
+  destTopAssets: { address: string }[];
+  quoteRequest: Partial<QuoteRequest>;
+  quotes: (QuoteResponse & L1GasFees)[];
+  quotesInitialLoadTime?: number;
+  quotesLastFetched?: number;
+  quotesLoadingStatus?: RequestStatus;
+  quoteFetchError?: string;
+  quotesRefreshCount: number;
+};


Rename BridgeControllerState to BridgeState

Define new BridgeControllerState

MajorLift · 2024-12-11T22:48:51Z

shared/types/bridge-status.ts

+export type BridgeStatusState = {
  txHistory: Record<SourceChainTxMetaId, BridgeHistoryItem>;
 };
+
+export type BridgeStatusControllerState = {
+  bridgeStatusState: BridgeStatusState;
+};


Rename BridgeStatusControllerState to BridgeStatusState

Define new BridgeStatusControllerState

MajorLift · 2024-12-11T22:49:02Z

app/scripts/controllers/bridge/constants.ts

+export const DEFAULT_BRIDGE_STATE: BridgeState = {
  bridgeFeatureFlags: {


Rename DEFAULT_BRIDGE_CONTROLLER_STATE to DEFAULT_BRIDGE_STATE

MajorLift · 2024-12-11T22:49:05Z

app/scripts/controllers/bridge/constants.ts

+export const DEFAULT_BRIDGE_CONTROLLER_STATE: BridgeControllerState = {
+  bridgeState: { ...DEFAULT_BRIDGE_STATE },


Define new DEFAULT_BRIDGE_CONTROLLER_STATE

MajorLift · 2024-12-11T22:49:12Z

app/scripts/controllers/bridge-status/constants.ts

+export const DEFAULT_BRIDGE_STATUS_STATE: BridgeStatusState = {
+  txHistory: {},
+};
+
 export const DEFAULT_BRIDGE_STATUS_CONTROLLER_STATE: BridgeStatusControllerState =
  {
-    txHistory: {},
+    bridgeStatusState: DEFAULT_BRIDGE_STATUS_STATE,
  };


Rename DEFAULT_BRIDGE_STATUS_CONTROLLER_STATE to DEFAULT_BRIDGE_STATUS_STATE

Define new DEFAULT_BRIDGE_STATUS_CONTROLLER_STATE

MajorLift · 2024-12-11T22:50:03Z

ui/pages/bridge/types.ts

The contents of this file were moved to shared/types/bridge.ts

MajorLift · 2024-12-11T22:51:35Z

shared/types/bridge.ts

+  symbol: string;
+  name: string;
+  decimals: number;
+  icon?: string;
+};
+
+export type QuoteRequest = {
+  walletAddress: string;
+  destWalletAddress?: string;
+  srcChainId: ChainId;
+  destChainId: ChainId;
+  srcTokenAddress: string;
+  destTokenAddress: string;
+  srcTokenAmount: string; // This is the amount sent
+  slippage: number;
+  aggIds?: string[];
+  bridgeIds?: string[];
+  insufficientBal?: boolean;
+  resetApproval?: boolean;
+  refuel?: boolean;
+};
+
+type Protocol = {
+  name: string;
+  displayName?: string;
+  icon?: string;
+};
+
+enum ActionTypes {
+  BRIDGE = 'bridge',
+  SWAP = 'swap',
+  REFUEL = 'refuel',
+}
+
+type Step = {
+  action: ActionTypes;
+  srcChainId: ChainId;
+  destChainId?: ChainId;
+  srcAsset: BridgeAsset;
+  destAsset: BridgeAsset;
+  srcAmount: string;
+  destAmount: string;
+  protocol: Protocol;
+};
+
+type RefuelData = Step;
+
+export type Quote = {
+  requestId: string;
+  srcChainId: ChainId;
+  srcAsset: BridgeAsset;
+  // This is amount sent - metabridge fee, however, some tokens have a fee of 0
+  // So sometimes it's equal to amount sent
+  srcTokenAmount: string;
+  destChainId: ChainId;
+  destAsset: BridgeAsset;
+  destTokenAmount: string;
+  feeData: Record<FeeType.METABRIDGE, FeeData> &
+    Partial<Record<FeeType, FeeData>>;
+  bridgeId: string;
+  bridges: string[];
+  steps: Step[];
+  refuel?: RefuelData;
+};
+
+export type QuoteResponse = {
+  quote: Quote;
+  approval: TxData | null;
+  trade: TxData;
+  estimatedProcessingTimeInSeconds: number;
+};
+
+export enum ChainId {
+  ETH = 1,
+  OPTIMISM = 10,
+  BSC = 56,
+  POLYGON = 137,
+  ZKSYNC = 324,
+  BASE = 8453,
+  ARBITRUM = 42161,
+  AVALANCHE = 43114,
+  LINEA = 59144,
+}
+
+export enum FeeType {
+  METABRIDGE = 'metabridge',
+  REFUEL = 'refuel',
+}
+export type FeeData = {
+  amount: string;
+  asset: BridgeAsset;
+};
+export type TxData = {
+  chainId: ChainId;
+  to: string;
+  from: string;
+  value: string;
+  data: string;
+  gasLimit: number | null;
+};


These are the former contents of ui/pages/bridge/types.ts.

They were moved to resolve restricted-path import and circular dependency issues.

MajorLift · 2024-12-11T22:53:36Z

app/scripts/controllers/bridge/bridge-controller.ts

 import {
+  BridgeControllerState,
+  BridgeFeatureFlagsKey,
  L1GasFees,
  QuoteRequest,
  QuoteResponse,
  TxData,
-  // TODO: Remove restricted import
-  // eslint-disable-next-line import/no-restricted-paths
-} from '../../../../ui/pages/bridge/types';


14 violations of import/no-restricted-paths are resolved in this PR.

metamaskbot · 2024-12-11T23:30:31Z

Builds ready [c8b4228]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 13, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1748 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1566	2054	1747	122	59
		domContentLoaded	1557	2041	1711	118	57
		load	1566	2055	1748	132	63
		domInteractive	24	82	47	19	9
		backgroundConnect	12	173	40	36	17
		firstReactRender	16	106	55	32	15
		getState	5	85	27	27	13
		initialActions	0	1	0	0	0
		loadScripts	1125	1489	1292	96	46
		setupStore	6	81	15	21	10
		uiStartup	1809	2795	2122	271	130

Bundle size diffs [🚀 Bundle size reduced!]

background: 31 Bytes (0.00%)
ui: -251 Bytes (-0.00%)
common: -504 Bytes (-0.01%)

dbrans · 2024-12-12T17:13:45Z

We’re removing the Extension Platform team from the reviewers list for now. If you need our input, feel free to re-add us—we’re happy to help!

metamaskbot · 2024-12-12T17:50:49Z

Builds ready [80ba0d3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1621 ± 64 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	263	1916	1486	425	204
		domContentLoaded	1400	1899	1602	131	63
		load	1408	1915	1621	132	64
		domInteractive	24	140	45	30	14
		backgroundConnect	6	57	17	12	6
		firstReactRender	15	77	35	24	11
		getState	4	48	21	17	8
		initialActions	0	1	0	0	0
		loadScripts	1045	1420	1195	107	51
		setupStore	6	53	11	11	5
		uiStartup	1640	2203	1852	155	75

Bundle size diffs [🚀 Bundle size reduced!]

background: 31 Bytes (0.00%)
ui: -251 Bytes (-0.00%)
common: -504 Bytes (-0.01%)

…TATE` constant

…_CONTROLLER_STATE` constant

…dencies

…nstants/bridge.ts`: `RequestStatus`, `METABRIDGE_CHAIN_TO_ADDRESS_MAP`

metamaskbot · 2024-12-13T20:09:34Z

Builds ready [d993ba2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1749 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	334	1996	1681	331	159
		domContentLoaded	1554	1976	1721	119	57
		load	1614	2001	1749	116	56
		domInteractive	25	73	40	16	7
		backgroundConnect	7	95	36	23	11
		firstReactRender	16	106	62	28	13
		getState	4	27	10	5	3
		initialActions	0	1	0	0	0
		loadScripts	1178	1542	1301	101	49
		setupStore	6	83	17	22	11
		uiStartup	1799	2793	2086	249	119

Bundle size diffs [🚀 Bundle size reduced!]

background: 31 Bytes (0.00%)
ui: -251 Bytes (-0.00%)
common: -504 Bytes (-0.01%)

…dgeControllerState-type

MajorLift · 2025-01-06T16:08:26Z

Superseded by #29254

metamaskbot added the team-wallet-framework label Dec 5, 2024

MajorLift changed the title ~~Fix broken BridgeControllerState, BridgeStatusControllerState types~~ fix: BridgeControllerState, BridgeStatusControllerState types do not represent full state object Dec 5, 2024

MajorLift added the team-tiger Tiger team (for tech debt reduction + performance improvements) label Dec 5, 2024

MajorLift self-assigned this Dec 5, 2024

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from 601c055 to ff835da Compare December 5, 2024 19:21

MajorLift requested a review from a team December 5, 2024 19:22

MajorLift marked this pull request as ready for review December 5, 2024 19:52

MajorLift requested review from micaelae and infiniteflower December 5, 2024 19:52

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from f9e9539 to 768412e Compare December 11, 2024 09:24

MajorLift added type-tech-debt Technical debt and removed team-wallet-framework labels Dec 11, 2024

MajorLift changed the title ~~fix: BridgeControllerState, BridgeStatusControllerState types do not represent full state object~~ fix: Bridge{,Status}Controller state types, circular dependencies Dec 11, 2024

MajorLift changed the title ~~fix: Bridge{,Status}Controller state types, circular dependencies~~ fix: Bridge{,Status}Controller state types, restricted-path dependencies Dec 11, 2024

MajorLift added the team-extension-platform Extension Platform team label Dec 11, 2024

MajorLift marked this pull request as draft December 11, 2024 14:12

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch 5 times, most recently from 9cc4bc8 to 2d5f4e2 Compare December 11, 2024 15:09

MajorLift changed the title ~~fix: Bridge{,Status}Controller state types, restricted-path dependencies~~ fix: Bridge{,Status}Controller state types and circular dependencies Dec 11, 2024

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from 2d5f4e2 to 0126ed3 Compare December 11, 2024 15:16

MajorLift marked this pull request as ready for review December 11, 2024 15:22

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from 0126ed3 to 4e4ae1d Compare December 11, 2024 15:29

MajorLift added the team-swaps label Dec 11, 2024

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from 2aa81b0 to 7a2578e Compare December 11, 2024 15:49

MajorLift commented Dec 11, 2024

View reviewed changes

MajorLift requested a review from a team as a code owner December 11, 2024 22:59

MajorLift added team-bridge and removed team-extension-platform Extension Platform team labels Dec 11, 2024

MajorLift enabled auto-merge December 11, 2024 23:41

dbrans removed the request for review from a team December 12, 2024 17:13

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from c8b4228 to 80ba0d3 Compare December 12, 2024 17:19

MajorLift added 11 commits December 13, 2024 13:47

Fix broken BridgeControllerState type, `DEFAULT_BRIDGE_CONTROLLER_S…

ffe63e3

…TATE` constant

Fix broken BridgeStatusControllerState type, `DEFAULT_BRIDGE_STATUS…

c36e053

…_CONTROLLER_STATE` constant

Rename BridgeState Redux slice type to BridgeSlice

ac6e177

Update test mocks

512e690

Move BridgeController types into shared to resolve circular depen…

79a2703

…dencies

Update import paths for BridgeController types

e81f2d3

Resolve merge conflicts with main

5963464

Resolve merge

f623ae9

Update import paths

d8fecf1

Move from app/scripts/controllers/bridge/constants.ts to `shared/co…

8c9d390

…nstants/bridge.ts`: `RequestStatus`, `METABRIDGE_CHAIN_TO_ADDRESS_MAP`

Update import paths

88c5311

MajorLift force-pushed the jongsun/fix/bridge-controller/241205-fix-BridgeControllerState-type branch from 80ba0d3 to 88c5311 Compare December 13, 2024 18:51

Add missing toTokenAmount property to QuoteMetadata

d993ba2

MajorLift added 2 commits December 17, 2024 22:16

Merge branch 'main' into jongsun/fix/bridge-controller/241205-fix-Bri…

6705f52

…dgeControllerState-type

Fix import path

5f65457

MajorLift closed this Jan 6, 2025

auto-merge was automatically disabled January 6, 2025 16:08
Pull request was closed

github-actions bot locked and limited conversation to collaborators Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: `Bridge{,Status}Controller` state types and restricted-path imports #28971

fix: `Bridge{,Status}Controller` state types and restricted-path imports #28971

MajorLift commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 10, 2024

MajorLift left a comment

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024

MajorLift Dec 11, 2024 •

edited

Loading

metamaskbot commented Dec 11, 2024

dbrans commented Dec 12, 2024

metamaskbot commented Dec 12, 2024

metamaskbot commented Dec 13, 2024

MajorLift commented Jan 6, 2025

		export const DEFAULT_BRIDGE_STATE: BridgeState = {
		bridgeFeatureFlags: {

		export const DEFAULT_BRIDGE_CONTROLLER_STATE: BridgeControllerState = {
		bridgeState: { ...DEFAULT_BRIDGE_STATE },

fix: Bridge{,Status}Controller state types and restricted-path imports #28971

fix: Bridge{,Status}Controller state types and restricted-path imports #28971

Conversation

MajorLift commented Dec 5, 2024 • edited Loading

Motivation

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 5, 2024

metamaskbot commented Dec 5, 2024

metamaskbot commented Dec 10, 2024

MajorLift left a comment

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024

Choose a reason for hiding this comment

MajorLift Dec 11, 2024 • edited Loading

Choose a reason for hiding this comment

metamaskbot commented Dec 11, 2024

dbrans commented Dec 12, 2024

metamaskbot commented Dec 12, 2024

metamaskbot commented Dec 13, 2024

MajorLift commented Jan 6, 2025

fix: `Bridge{,Status}Controller` state types and restricted-path imports #28971

fix: `Bridge{,Status}Controller` state types and restricted-path imports #28971

MajorLift commented Dec 5, 2024 •

edited

Loading

MajorLift Dec 11, 2024 •

edited

Loading