chore: Extracting the type for wrapper in rpc-method-middleware handlers #23589

NiranjanaBinoy · 2024-03-19T18:21:05Z

Description

Part of #23014
The wrapper used by rpc-method-middleware handlers is having the same structure, so I am extracting the type to a separate re-usable file.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-19T18:21:16Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-03-26T18:04:20Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.27%. Comparing base (9dbcea2) to head (777efe9).
Report is 184 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23589   +/-   ##
========================================
  Coverage    68.27%   68.27%           
========================================
  Files         1141     1141           
  Lines        43873    43873           
  Branches     11765    11765           
========================================
  Hits         29954    29954           
  Misses       13919    13919

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-03-27T21:33:48Z

Builds ready [4461fd3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (859 ± 555 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	325	154	68	33
		domContentLoaded	13	100	34	22	11
		load	62	2810	859	1157	555
		domInteractive	13	100	34	22	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-03-29T15:16:21Z

Builds ready [b21ec54]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (795 ± 455 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	219	128	37	18
		domContentLoaded	10	82	38	23	11
		load	59	2432	795	947	455
		domInteractive	10	82	38	23	11

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-08T21:46:06Z

Builds ready [18f6b0a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1258 ± 464 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	371	149	73	35
		domContentLoaded	13	75	32	18	9
		load	66	2267	1258	967	464
		domInteractive	13	75	32	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-04-09T17:54:32Z

Builds ready [fc30dca]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (886 ± 474 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	76	336	128	60	29
		domContentLoaded	16	100	30	18	9
		load	67	2204	886	987	474
		domInteractive	16	100	30	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

github-actions · 2024-06-08T18:04:23Z

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

github-actions · 2024-06-22T18:04:53Z

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

…file

metamaskbot · 2025-01-31T18:43:51Z

Builds ready [bcb3345]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (1630 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	404	1979	1572	288	138
		domContentLoaded	1504	1965	1609	104	50
		load	1516	1979	1630	107	52
		domInteractive	24	107	40	22	11
		backgroundConnect	11	60	23	17	8
		firstReactRender	16	98	42	28	13
		getState	5	57	12	14	7
		initialActions	0	1	0	0	0
		loadScripts	1069	1401	1164	84	40
		setupStore	8	76	25	26	12
		uiStartup	1731	2374	1926	194	93

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.35 MiB (30.33%)
ui: 165.43 KiB (2.14%)
common: 1.04 MiB (12.91%)

DDDDDanica · 2025-02-03T16:47:01Z

LGTM !

NiranjanaBinoy self-assigned this Mar 19, 2024

NiranjanaBinoy added the team-extension-platform Extension Platform team label Mar 19, 2024

metamaskbot added the in-progress label Mar 19, 2024

NiranjanaBinoy changed the title ~~Extracting the type for wrapper in rpc-method-middleware handlers~~ refactor: Extracting the type for wrapper in rpc-method-middleware handlers Mar 19, 2024

NiranjanaBinoy changed the title ~~refactor: Extracting the type for wrapper in rpc-method-middleware handlers~~ chore: Extracting the type for wrapper in rpc-method-middleware handlers Mar 19, 2024

NiranjanaBinoy mentioned this pull request Mar 28, 2024

refactor: Typescript conversion of get-provider-state.js #23635

Merged

13 tasks

github-actions bot added the stale issues and PRs marked as stale label Jun 8, 2024

github-actions bot closed this Jun 22, 2024

NiranjanaBinoy reopened this Jun 24, 2024

github-actions bot removed the stale issues and PRs marked as stale label Jun 24, 2024

NiranjanaBinoy closed this Jun 25, 2024

github-actions bot removed the in-progress label Jun 25, 2024

github-actions bot locked and limited conversation to collaborators Jun 25, 2024

MajorLift reopened this Jan 31, 2025

NiranjanaBinoy added 8 commits January 31, 2025 12:58

extracting the handles wrapper from rpc-middleware files to separate …

d123d43

…file

updating with a helper file

49d578f

updating the naming case

d6b95c7

remaining the types and rearranging the order

3339131

updating jsdoc

dabf5d4

adding the types needed for add-ethereum-chain

10171c2

adding the types needed for request_accounts file

a41ca0d

adding the types for switch-ethereum-chain

6dc674e

NiranjanaBinoy added 2 commits January 31, 2025 12:58

updating HandlerWrapper.methodNames type

848a54c

changing the file name

22d92d7

MajorLift force-pushed the extract-wrapper-type branch from c23d74b to 22d92d7 Compare January 31, 2025 18:00

Remove deprecated ProviderConfig

bcb3345

MajorLift changed the base branch from develop to main January 31, 2025 18:08

metamaskbot added the external-contributor label Jan 31, 2025

MajorLift removed the external-contributor label Jan 31, 2025

MajorLift marked this pull request as ready for review January 31, 2025 18:35

MajorLift requested review from a team and DDDDDanica January 31, 2025 18:35

MajorLift self-assigned this Jan 31, 2025

MetaMask unlocked this conversation Jan 31, 2025

MajorLift enabled auto-merge February 3, 2025 03:26

DDDDDanica approved these changes Feb 3, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Extracting the type for wrapper in rpc-method-middleware handlers #23589

chore: Extracting the type for wrapper in rpc-method-middleware handlers #23589

NiranjanaBinoy commented Mar 19, 2024 •

edited

Loading

github-actions bot commented Mar 19, 2024

codecov bot commented Mar 26, 2024

metamaskbot commented Mar 27, 2024

metamaskbot commented Mar 29, 2024

metamaskbot commented Apr 8, 2024

metamaskbot commented Apr 9, 2024

github-actions bot commented Jun 8, 2024

github-actions bot commented Jun 22, 2024

metamaskbot commented Jan 31, 2025

DDDDDanica commented Feb 3, 2025

chore: Extracting the type for wrapper in rpc-method-middleware handlers #23589

Are you sure you want to change the base?

chore: Extracting the type for wrapper in rpc-method-middleware handlers #23589

Conversation

NiranjanaBinoy commented Mar 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 19, 2024

codecov bot commented Mar 26, 2024

Codecov Report

metamaskbot commented Mar 27, 2024

metamaskbot commented Mar 29, 2024

metamaskbot commented Apr 8, 2024

metamaskbot commented Apr 9, 2024

github-actions bot commented Jun 8, 2024

github-actions bot commented Jun 22, 2024

metamaskbot commented Jan 31, 2025

DDDDDanica commented Feb 3, 2025

NiranjanaBinoy commented Mar 19, 2024 •

edited

Loading