Prevent redux state mutation (#7598)

The `txParams` property of a transaction in Redux state was being mutated. The mutation is now prevented with a shallow clone.
MetaMask · Dec 5, 2019 · 7744992 · 7744992
1 parent ff6b254
commit 7744992
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/ui/app/ducks/metamask/metamask.js b/ui/app/ducks/metamask/metamask.js
@@ -322,7 +322,9 @@ function reduceMetamask (state, action) {
       let { selectedAddressTxList } = metamaskState
       selectedAddressTxList = selectedAddressTxList.map(tx => {
         if (tx.id === txId) {
-          tx.txParams = value
+          const newTx = Object.assign({}, tx)
+          newTx.txParams = value
+          return newTx
         }
         return tx
       })