Skip to content

Commit

Permalink
Revert "chore: update Node.js to v20 (#22755)"
Browse files Browse the repository at this point in the history
This reverts removal of support for node v18 in #22755,
and suggests using node v18 instead of node v20 for local dev.

See: yarnpkg/berry#5452
  • Loading branch information
legobeat committed Feb 16, 2024
1 parent befc516 commit 0db14d5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20
v18
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ To learn how to contribute to the MetaMask project itself, visit our [Internal D

## Building locally

- Install [Node.js](https://nodejs.org) version 20
- Install [Node.js](https://nodejs.org) version 18
- If you are using [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) (recommended) running `nvm use` will automatically choose the right node version for you.
- Enable Corepack by executing the command `corepack enable` within the metamask-extension project. Corepack is a utility included with Node.js by default. It manages Yarn on a per-project basis, using the version specified by the `packageManager` property in the project's package.json file. Please note that modern releases of [Yarn](https://yarnpkg.com/getting-started/install) are not intended to be installed globally or via npm.
- Duplicate `.metamaskrc.dist` within the root and rename it to `.metamaskrc` by running `cp .metamaskrc{.dist,}`.
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@
"@types/jest": "^29.1.2",
"@types/madge": "^5.0.0",
"@types/mocha": "^10.0.3",
"@types/node": "^20",
"@types/node": "^18",
"@types/pify": "^5.0.1",
"@types/pump": "^1.1.1",
"@types/react": "^16.9.53",
Expand Down Expand Up @@ -586,7 +586,7 @@
"yargs": "^17.0.1"
},
"engines": {
"node": ">= 20",
"node": ">= 18",
"yarn": "^4.0.2"
},
"lavamoat": {
Expand Down

0 comments on commit 0db14d5

Please sign in to comment.