This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
Escalate errors on RPC responses #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2019
Remove Babel 6 and support Node 10 across internal dependency graph
MetaMask/metamask-extension#7034
Closed
kumavis
approved these changes
Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors on RPC responses are now detected in the
next()andend()handlers and they are escalated as thoughend(response.error)was called.Responses are also sanitized by deleting
response.resultifresponse.erroris present, as mandated by the JSON RPC 2.0 spec.Version bump:
5.1.2->5.1.3Fixes #11