Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated eth-json-rpc-middleware on 4.4.0 #15

Merged
merged 1 commit into from
Sep 2, 2020
Merged

updated eth-json-rpc-middleware on 4.4.0 #15

merged 1 commit into from
Sep 2, 2020

Conversation

logvik
Copy link
Contributor

@logvik logvik commented Dec 20, 2019 •
edited
Loading

@logvik
Copy link
Contributor Author

logvik commented Dec 27, 2019

@kumavis, please review these changes

@logvik
Copy link
Contributor Author

logvik commented Jan 13, 2020

@danfinlay Could you able to help to merge this PR? I have to do the main PR to metamask-extension after all dependencies will be updated in NPM.

@logvik logvik mentioned this pull request Jan 13, 2020
Closed
Gudahtt
Gudahtt previously requested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a yarn.lock file got added somehow; that should be removed. This repository is still using npm.

@logvik
Copy link
Contributor Author

logvik commented Jan 14, 2020

@Gudahtt should I squash commits?

@Gudahtt
Copy link
Member

Gudahtt commented Jan 14, 2020

Squashing is not required, as we can squash when the PR is merged.

@logvik logvik requested a review from a team as a code owner September 2, 2020 18:58
whymarrh
whymarrh approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased this on the latest, thanks @logvik!

@whymarrh whymarrh merged commit b0407f8 into MetaMask:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Gudahtt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logvik @Gudahtt @whymarrh