Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Bump all ESLint dependencies #351

Merged
merged 8 commits into from
Jun 4, 2024
Merged

BREAKING: Bump all ESLint dependencies #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9786db8
Bump all ESLint dependencies
Mrtenz Mar 27, 2024
69ba503
Update validation script to handle breaking changes
Mrtenz Mar 27, 2024
3a82742
Update @typescript-eslint/eslint-plugin recommended rules name
Mrtenz Mar 27, 2024
7e7a6f6
Revert Prettier bump
Mrtenz May 29, 2024
b6b8a97
Revert more Prettier changes
Mrtenz May 29, 2024
f704d16
Update rules snapshot
Mrtenz May 29, 2024
c512e92
Widen range of eslint-plugin-jsdoc
Mrtenz May 29, 2024
7bc6519
Merge branch 'main' into mrtenz/bump-dependencies
mcmire Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,24 +20,24 @@
"test": "jest"
},
"devDependencies": {
"@eslint/eslintrc": "^1.3.0",
"@eslint/js": "^8.45.0",
"@lavamoat/allow-scripts": "^2.3.1",
"@metamask/auto-changelog": "^3.0.0",
"@eslint/eslintrc": "^3.0.2",
"@eslint/js": "^8.57.0",
"@lavamoat/allow-scripts": "^3.0.4",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eslint-config": "^12.0.0",
"@metamask/eslint-config-nodejs": "^12.0.0",
"@metamask/utils": "^8.1.0",
"@types/jest": "^29.5.2",
"eslint": "^8.45.0",
"@metamask/utils": "^8.4.0",
"@types/jest": "^29.5.12",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jest": "^27.1.5",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-n": "^15.7.0",
"eslint-plugin-jest": "^27.9.0",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-n": "^16.6.2",
"eslint-plugin-prettier": "^4.2.1",
"fast-deep-equal": "^3.1.3",
"globals": "^13.17.0",
"jest": "^29.6.1",
"globals": "^15.0.0",
"jest": "^29.7.0",
"prettier": "^2.7.1",
"prettier-plugin-packagejson": "^2.2.18"
},
Expand Down
6 changes: 3 additions & 3 deletions packages/base/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ Our default export contains a base set of ESLint rules for ES6+:

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
10 changes: 5 additions & 5 deletions packages/base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"eslint": "^8.45.0",
"@metamask/auto-changelog": "^3.4.4",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"eslint": "^8.27.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^39.6.2 || ^41 || ^43.0.7",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we used this range before, but I replaced it with the latest (Node.js 16-compatible) version. I can revert if there's a good reason to have this range.

cc @legobeat

Copy link
Contributor

@legobeat legobeat Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context and previous discussion:

"eslint-plugin-jsdoc": ">=43.0.7 <48",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.1.1",
"prettier": "^2.7.1"
Expand Down
16 changes: 9 additions & 7 deletions packages/base/rules-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,13 @@
"jsdoc/require-returns-type": "error",
"jsdoc/require-yields": "error",
"jsdoc/require-yields-check": "error",
"jsdoc/tag-lines": "error",
"jsdoc/tag-lines": [
"error",
"any",
{
"startLines": 1
}
],
"jsdoc/valid-types": "error",
"jsx-quotes": "off",
"key-spacing": "off",
Expand All @@ -221,12 +227,7 @@
"lines-around-comment": "off",
"lines-between-class-members": "error",
"max-len": "off",
"max-statements-per-line": [
"error",
{
"max": 1
}
],
"max-statements-per-line": "off",
"multiline-ternary": "off",
"new-cap": [
"error",
Expand Down Expand Up @@ -3393,6 +3394,7 @@
"valid-typeof": "error",
"vue/array-bracket-newline": "off",
"vue/array-bracket-spacing": "off",
"vue/array-element-newline": "off",
"vue/arrow-spacing": "off",
"vue/block-spacing": "off",
"vue/block-tag-newline": "off",
Expand Down
14 changes: 7 additions & 7 deletions packages/base/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,6 @@ module.exports = {
},
],
'lines-between-class-members': 'error',
'max-statements-per-line': [
'error',
{
max: 1,
},
],
Comment on lines -101 to -106
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our validation script was complaining about this being handled by Prettier.

'new-cap': [
'error',
{
Expand Down Expand Up @@ -392,7 +386,13 @@ module.exports = {
'jsdoc/require-returns-type': 'error',
'jsdoc/require-yields': 'error',
'jsdoc/require-yields-check': 'error',
'jsdoc/tag-lines': 'error',
'jsdoc/tag-lines': [
'error',
'any',
{
startLines: 1,
},
],
Comment on lines +389 to +395
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK this matches the previous behaviour, where one line between the description and the first tag is required.

'jsdoc/valid-types': 'error',

'promise/no-multiple-resolved': 'error',
Expand Down
8 changes: 4 additions & 4 deletions packages/browser/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ Our default export contains a base set of ESLint rules for ES6+:

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-browser@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
@metamask/eslint-config-browser@^12.1.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
10 changes: 5 additions & 5 deletions packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"eslint": "^8.45.0",
"@metamask/auto-changelog": "^3.4.4",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.27.0"
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0"
},
"engines": {
"node": "^16.20 || ^18.18 || >=20"
Expand Down
6 changes: 3 additions & 3 deletions packages/commonjs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ MetaMask's ESLint configuration for projects using CommonJS.
```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-commonjs@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config-commonjs@^12.1.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
10 changes: 5 additions & 5 deletions packages/commonjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"eslint": "^8.45.0",
"@metamask/auto-changelog": "^3.4.4",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.27.0"
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0"
},
"engines": {
"node": "^16.20 || ^18.18 || >=20"
Expand Down
10 changes: 5 additions & 5 deletions packages/jest/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ MetaMask's [Jest](https://jestjs.io/) ESLint configuration.

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-jest@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
@metamask/eslint-config-jest@^12.1.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-jest@^27.1.5 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-jest@^27.9.0 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
14 changes: 7 additions & 7 deletions packages/jest/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.45.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jest": "^27.1.5",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-jest": "^27.9.0",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.27.0",
"eslint-plugin-jest": "^27.1.5"
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0",
"eslint-plugin-jest": "^27.9.0"
},
"engines": {
"node": "^16.20 || ^18.18 || >=20"
Expand Down
10 changes: 5 additions & 5 deletions packages/mocha/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ MetaMask's [Mocha](https://mochajs.org/) ESLint configuration.

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-mocha@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
@metamask/eslint-config-mocha@^12.1.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-mocha@^10.1.0 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-mocha@^10.4.1 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
14 changes: 7 additions & 7 deletions packages/mocha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.45.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-mocha": "^10.1.0",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-mocha": "^10.4.1",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.27.0",
"eslint-plugin-mocha": "^10.1.0"
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0",
"eslint-plugin-mocha": "^10.4.1"
},
"engines": {
"node": "^16.20 || ^18.18 || >=20"
Expand Down
1 change: 1 addition & 0 deletions packages/mocha/rules-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"mocha/consistent-spacing-between-blocks": "error",
"mocha/handle-done-callback": "error",
"mocha/max-top-level-suites": [
"error",
Expand Down
10 changes: 5 additions & 5 deletions packages/nodejs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ MetaMask's [Node.js](https://nodejs.org) ESLint configuration.

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-nodejs@^12.0.0 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
@metamask/eslint-config-nodejs@^12.1.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-n@^15.7.0 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-n@^16.6.2 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
16 changes: 8 additions & 8 deletions packages/nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,20 @@
"test": "eslint ."
},
"devDependencies": {
"@metamask/auto-changelog": "^3.0.0",
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.45.0",
"@metamask/auto-changelog": "^3.4.4",
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-import": "~2.26.0",
"eslint-plugin-jsdoc": "^41.1.2",
"eslint-plugin-n": "^15.7.0",
"eslint-plugin-jsdoc": "^47.0.2",
"eslint-plugin-n": "^16.6.2",
"eslint-plugin-prettier": "^4.2.1",
"prettier": "^2.7.1"
},
"peerDependencies": {
"@metamask/eslint-config": "^12.0.0",
"eslint": "^8.27.0",
"eslint-plugin-n": "^15.7.0"
"@metamask/eslint-config": "^12.2.0",
"eslint": "^8.57.0",
"eslint-plugin-n": "^16.6.2"
},
"engines": {
"node": "^16.20 || ^18.18 || >=20"
Expand Down
12 changes: 6 additions & 6 deletions packages/typescript/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ MetaMask's [TypeScript](https://www.typescriptlang.org) ESLint configuration.

```bash
yarn add --dev \
@metamask/eslint-config@^12.0.0 \
@metamask/eslint-config-typescript@^12.0.0 \
@typescript-eslint/eslint-plugin@^5.42.1 \
@typescript-eslint/parser@^5.42.1 \
eslint@^8.45.0 \
@metamask/eslint-config@^12.2.0 \
@metamask/eslint-config-typescript@^12.1.0 \
@typescript-eslint/eslint-plugin@^6.21.0 \
@typescript-eslint/parser@^6.21.0 \
eslint@^8.57.0 \
eslint-config-prettier@^8.5.0 \
eslint-plugin-import@~2.26.0 \
eslint-plugin-jsdoc@^41.1.2 \
eslint-plugin-jsdoc@^47.0.2 \
eslint-plugin-prettier@^4.2.1 \
eslint-plugin-promise@^6.1.1 \
prettier@^2.7.1
Expand Down
Loading
Loading