Skip to content

Commit

Permalink
Bump min Node to 16, and use LTS Node for dev (#332)
Browse files Browse the repository at this point in the history
**This change is breaking.**

We could bump this monorepo to Node 18, but since these packages are
heavily depended upon, we don't need to do that yet until we've
confirmed all other projects are using 18.

Using the LTS version of Node puts us on a more modern version for
development (and also happens to fix the `.nvmrc` file so `asdf` can
read it).

Also fix the CI matrix so it matches the versions we actually support.

---------

Co-authored-by: legobt <[email protected]>
  • Loading branch information
mcmire and legobeat authored Dec 1, 2023
1 parent da6a32a commit efec22f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down Expand Up @@ -57,7 +57,7 @@ jobs:
- prepare
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 19.x]
node-version: [16.x, 18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
lts/*
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ correctly specify their peer dependencies.

### Setup

- Install [Node.js](https://nodejs.org) version 14
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm use` will automatically choose the right node version for you.
- Install the current LTS version of [Node.js](https://nodejs.org)
- If you are using [nvm](https://github.com/creationix/nvm#installation) (recommended) running `nvm install` will install the latest version and running `nvm use` will automatically choose the right node version for you.
- Install [Yarn v3](https://yarnpkg.com/getting-started/install)
- Run `yarn install` to install dependencies and run any required post-install scripts

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"packageManager": "[email protected]",
"engines": {
"node": ">=14.0.0"
"node": "^16.20 || ^18.18 || >=20"
},
"lavamoat": {
"allowScripts": {
Expand Down

0 comments on commit efec22f

Please sign in to comment.