Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow npm:name@version dependency redirections in manifest #158

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 26, 2024

This allows specifying dependency versions in the format npm:{x}@{y}, where:

  • x is valid package name
  • y is valid semver range

The package is currently experiencing failure running in https://github.com/MetaMask/core/ due to https://github.com/MetaMask/core/blob/main/packages/controller-utils/package.json#L58.

This fixes that.

@legobeat legobeat force-pushed the allow-redirected-dependencies branch 2 times, most recently from 3687bea to 5bc6b66 Compare October 26, 2024 00:15
@legobeat legobeat force-pushed the allow-redirected-dependencies branch from 5bc6b66 to ac287c4 Compare October 26, 2024 00:18
Copy link

socket-security bot commented Oct 26, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 4.45 kB types

View full report↗︎

@legobeat legobeat marked this pull request as ready for review October 26, 2024 00:19
@legobeat legobeat requested a review from a team as a code owner October 26, 2024 00:19
@legobeat legobeat changed the title feat: allow "npm:name@version" dependency redirections in manifest feat: allow npm:name@version dependency redirections in manifest Oct 26, 2024
@legobeat legobeat force-pushed the allow-redirected-dependencies branch 3 times, most recently from 45bf613 to f93a3a4 Compare October 26, 2024 00:37
@legobeat legobeat force-pushed the allow-redirected-dependencies branch from f93a3a4 to 4f5d575 Compare October 26, 2024 00:41
@legobeat legobeat merged commit 51f2db6 into MetaMask:main Oct 28, 2024
14 checks passed
legobeat added a commit to legobeat/create-release-branch that referenced this pull request Oct 29, 2024
legobeat added a commit to legobeat/create-release-branch that referenced this pull request Oct 29, 2024
legobeat added a commit that referenced this pull request Oct 29, 2024
…est (#158) (#159)

feat: allow `npm:name@version` dependency redirections in manifest (#158)
Gudahtt added a commit that referenced this pull request Nov 1, 2024
* origin/main:
  feat: allow `npm:name@version` dependency redirections in manifest (#158)
  4.0.0 (#157)
  BREAKING: Bump `@metamask/auto-changelog` to `^4.0.0`, and bump related dependencies (#156)
  chore(devdeps): @lavamoat/allow-scripts@^2.3.1->^3.1.0 (#146)
Gudahtt added a commit that referenced this pull request Nov 1, 2024
* [3.x] feat: allow `npm:name@version` dependency redirections in manifest (#158) (#159)

feat: allow `npm:name@version` dependency redirections in manifest (#158)

* 3.1.0 (#160)

* 3.1.0

* chore: update changelog

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>

---------

Co-authored-by: legobeat <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: legobt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants