Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure wallet scope does not insert accounts #5374

Merged

Conversation

ffmcgee725
Copy link
Member

Explanation

This pull request fixes this issue.

We appear to be adding an account to the wallet scope

Resulting in this failing CI for our Multichain Flask PR

we should add it to the wallet:eip155 scope (as currently done), but not just wallet.

The fix involves refactoring core Multichain package so that creating the scopeObjects for each entry, we make sure that in wallet scope string, the accounts property is not populated.

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@ffmcgee725
Copy link
Member Author

@metamaskbot publish-preview

@ffmcgee725 ffmcgee725 marked this pull request as ready for review February 21, 2025 11:54
@ffmcgee725 ffmcgee725 requested a review from a team as a code owner February 21, 2025 11:54
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "24.0.0-preview-dbdf1da",
  "@metamask-previews/address-book-controller": "6.0.3-preview-dbdf1da",
  "@metamask-previews/announcement-controller": "7.0.3-preview-dbdf1da",
  "@metamask-previews/approval-controller": "7.1.3-preview-dbdf1da",
  "@metamask-previews/assets-controllers": "51.0.0-preview-dbdf1da",
  "@metamask-previews/base-controller": "8.0.0-preview-dbdf1da",
  "@metamask-previews/bridge-controller": "1.0.0-preview-dbdf1da",
  "@metamask-previews/bridge-status-controller": "1.0.0-preview-dbdf1da",
  "@metamask-previews/build-utils": "3.0.3-preview-dbdf1da",
  "@metamask-previews/composable-controller": "11.0.0-preview-dbdf1da",
  "@metamask-previews/controller-utils": "11.5.0-preview-dbdf1da",
  "@metamask-previews/earn-controller": "0.4.0-preview-dbdf1da",
  "@metamask-previews/ens-controller": "15.0.2-preview-dbdf1da",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-dbdf1da",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-dbdf1da",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-dbdf1da",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-dbdf1da",
  "@metamask-previews/keyring-controller": "19.2.0-preview-dbdf1da",
  "@metamask-previews/logging-controller": "6.0.4-preview-dbdf1da",
  "@metamask-previews/message-manager": "12.0.1-preview-dbdf1da",
  "@metamask-previews/multichain": "2.1.1-preview-dbdf1da",
  "@metamask-previews/multichain-network-controller": "0.1.1-preview-dbdf1da",
  "@metamask-previews/multichain-transactions-controller": "0.4.0-preview-dbdf1da",
  "@metamask-previews/name-controller": "8.0.3-preview-dbdf1da",
  "@metamask-previews/network-controller": "22.2.1-preview-dbdf1da",
  "@metamask-previews/notification-services-controller": "0.21.0-preview-dbdf1da",
  "@metamask-previews/permission-controller": "11.0.6-preview-dbdf1da",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-dbdf1da",
  "@metamask-previews/phishing-controller": "12.3.2-preview-dbdf1da",
  "@metamask-previews/polling-controller": "12.0.3-preview-dbdf1da",
  "@metamask-previews/preferences-controller": "15.0.2-preview-dbdf1da",
  "@metamask-previews/profile-sync-controller": "8.1.0-preview-dbdf1da",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-dbdf1da",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-dbdf1da",
  "@metamask-previews/remote-feature-flag-controller": "1.5.0-preview-dbdf1da",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-dbdf1da",
  "@metamask-previews/signature-controller": "23.2.1-preview-dbdf1da",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-dbdf1da",
  "@metamask-previews/transaction-controller": "46.0.0-preview-dbdf1da",
  "@metamask-previews/user-operation-controller": "25.0.0-preview-dbdf1da"
}

@adonesky1 adonesky1 enabled auto-merge (squash) February 21, 2025 17:34
@adonesky1 adonesky1 merged commit f26ed13 into main Feb 21, 2025
136 checks passed
@adonesky1 adonesky1 deleted the fix/accounts-added-to-wallet-scope-in-caip25-caveat-value branch February 21, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants