fix: make sure wallet scope does not insert accounts #5374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This pull request fixes this issue.
We appear to be adding an
account
to the wallet scopeResulting in this failing CI for our Multichain Flask PR
we should add it to the
wallet:eip155
scope (as currently done), but not justwallet
.The fix involves refactoring core Multichain package so that creating the
scopeObjects
for each entry, we make sure that inwallet
scope string, the accounts property is not populated.References
Changelog
@metamask/package-a
@metamask/package-b
Checklist