Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not call the snap to get rates if assets are empty #5370

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Feb 21, 2025

Explanation

This pull request aims to update the multichainAssetsRatesController so that if the assets list is empty, the Snap call is skipped and execution returns immediately.

References

Changelog

@metamask/assets-controllers

  • FIXED: if the assets list is empty, the Snap call is skipped and execution returns immediately.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@salimtb salimtb marked this pull request as ready for review February 21, 2025 10:00
@salimtb salimtb requested a review from a team as a code owner February 21, 2025 10:00
// Publish a selectedAccountChange event.
// @ts-expect-error-next-line
messenger.publish('MultichainAssetsController:stateChange', {
accountsAssets: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (happy to ignore since this is a test).
Could we satisfy the type by using the defaultState from the controller? Or is the types quite complex?

const mockNewState = { ...defaultState }
mockNewState.accountAssets = { account: [] }
messenger.publish('MultichainAssetsController:stateChange', mockNewState)

@salimtb salimtb merged commit a9c6e11 into main Feb 21, 2025
136 checks passed
@salimtb salimtb deleted the fix/snap-not-called-if-assets-empty branch February 21, 2025 13:04
github-merge-queue bot pushed a commit to MetaMask/metamask-extension that referenced this pull request Feb 24, 2025
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates the `@metamask/assets-controller` to the latest version, in
order to get [this fix](MetaMask/core#5370) in.
## **Related issues**

Fixes: MetaMask/core#5370

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: MetaMask Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants