[composable-controller] perf: Optimize expensive reduce operations, fix metadata instantiation#4968

Merged

MajorLift merged 25 commits intomainfrom jongsun/perf/composable-controller/241124-remove-expensive-reduce

Dec 5, 2024

+230-86

Commits on Dec 3, 2024

perf: Convert reduce operations to re-use output object instead of creating new tmp object every iteration
MajorLift
committed
fix: incorrect logic for assigning fall-back metadata properties for non-V2 controllers
MajorLift
committed
fix: type issue with assigning property to generic type
MajorLift
committed
feat: **BREAKING:** Re-define controllers constructor option from array to object
MajorLift
committed
fix: Check that input is V1/V2 controller when instantiating ComposableController state and metadata fields
MajorLift
committed
test: Update tests
MajorLift
committed
Update changelogs
MajorLift
committed
Update comments
MajorLift
committed
perf: Replace Object.assign with property assignments
MajorLift
committed
Assign metadata to each child controller instead of to individual nested properties of child controller state
MajorLift
committed
Remove non-controller properties from state, metadata fields
MajorLift
committed
test: fix missing stateChange events in test composable-controller messenger events allowlists
MajorLift
committed
Update jsdoc comments
MajorLift
committed
Fix undefined property deletion behavior
MajorLift
committed
Apply eslint-disable to entire test file to allow PascalCase controller name object keys
MajorLift
committed
Fix types
MajorLift
committed
Update changelog
MajorLift
committed
Wrap delete operations for non-controllers in try-catch block
MajorLift
committed
Add tests for stateChange events that are not defined or omitted from allowlist
MajorLift
committed
Update packages/composable-controller/CHANGELOG.md
MajorLift
committed
Add links to changelog entries
MajorLift
authored
Add comments explaining reduce implementation and type assertions
MajorLift
committed
Rename QuxController to ControllerWithoutStateChangeEvent
MajorLift
committed
Rename ChildControllers type parameter to ChildControllersMap
MajorLift
committed

Commits on Dec 4, 2024

Merge branch 'main' into jongsun/perf/composable-controller/241124-remove-expensive-reduce
MajorLift
authored

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[composable-controller] perf: Optimize expensive reduce operations, fix metadata instantiation#4968

Commits on Dec 3, 2024

perf: Convert reduce operations to re-use output object instead of creating new tmp object every iteration

fix: incorrect logic for assigning fall-back metadata properties for non-V2 controllers

fix: type issue with assigning property to generic type

feat: BREAKING: Re-define `controllers` constructor option from array to object

fix: Check that input is V1/V2 controller when instantiating ComposableController state and metadata fields

test: Update tests

Update changelogs

Update comments

perf: Replace `Object.assign` with property assignments

Assign metadata to each child controller instead of to individual nested properties of child controller state

Remove non-controller properties from state, metadata fields

test: fix missing `stateChange` events in test composable-controller messenger events allowlists

Update jsdoc comments

Fix undefined property deletion behavior

Apply `eslint-disable` to entire test file to allow PascalCase controller name object keys

Fix types

Update changelog

Wrap delete operations for non-controllers in try-catch block

Add tests for `stateChange` events that are not defined or omitted from allowlist

Update packages/composable-controller/CHANGELOG.md

Add links to changelog entries

Add comments explaining reduce implementation and type assertions

Rename `QuxController` to `ControllerWithoutStateChangeEvent`

Rename `ChildControllers` type parameter to `ChildControllersMap`

Commits on Dec 4, 2024

Merge branch 'main' into jongsun/perf/composable-controller/241124-remove-expensive-reduce