Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add methods required by smart transaction controller (patch v7) #3936

Conversation

vinistevam
Copy link
Contributor

Explanation

References

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@MajorLift
Copy link
Contributor

MajorLift commented Feb 27, 2024

Hi! I noticed that all of the eslint-disable directives and TODOs for converting interfaces to type aliases have been removed in this PR.

The shared libraries team relies on those comments to mark interface instances that were pre-existing at the time we enabled @typescript-eslint/consistent-type-definitions, and to keep track of remaining interfaces that need to be converted.

We'd appreciate it if you could restore them in this PR before you mark it as ready for review.

Additionally, any new types being added should be in the form of type aliases, not interfaces.

Please refer to the following for previous discussions on this matter:

Edit: This PR seems to supersede #3900, but if not, please apply the same to that and any previous PRs as well.

Edit2: Is this PR maybe not intended to be merged into core?

@vinistevam vinistevam closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants