RFC: Redesigned controller API #312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
changed the title
Gudahtt
changed the title
Gudahtt
changed the title
This represents a prototype implementation of a new controller API design. The motivations for this are written about in this document: https://docs.google.com/document/d/1DjtFfNB0JuziijGqs4h3vW8PL8zCI6zuaovqvSHbJ2o/edit#heading=h.mtvpfhpuzjof A new base controller has been introduced (`base-controller-v2.ts`), and the `CurrencyRateController` has been updated to use it. All other controllers remain unchanged. Note that the `CurrencyRateController` no longer works correctly with the `ComposableController` - I didn't think that was worth the effort to get working.
Gudahtt
force-pushed
the
background-refactor-prototype
branch
from
f081502 to
a37c7c3
Compare
|
Closing in favour of #372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents a prototype implementation of a new controller API design. The motivations for this are written about in this document: https://docs.google.com/document/d/1DjtFfNB0JuziijGqs4h3vW8PL8zCI6zuaovqvSHbJ2o/edit#heading=h.mtvpfhpuzjof
A new base controller has been introduced (
base-controller-v2.ts), and theCurrencyRateControllerhas been updated to use it. All other controllers remain unchanged.Note that the
CurrencyRateControllerno longer works correctly with theComposableController- I didn't think that was worth the effort to get working.