Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quid Ika Token #1043

Merged
merged 7 commits into from
Aug 11, 2022
Merged

Add Quid Ika Token #1043

merged 7 commits into from
Aug 11, 2022

Conversation

ShailChoksi
Copy link
Contributor

@ShailChoksi ShailChoksi requested review from MRabenda and a team as code owners May 7, 2022 05:39
MRabenda
MRabenda reviewed May 9, 2022
View reviewed changes
contract-map.json Outdated Show resolved Hide resolved
@ShailChoksi
Copy link
Contributor Author

@MRabenda bump?

@ShailChoksi
Copy link
Contributor Author

Am I still missing something here?

@ShailChoksi
Copy link
Contributor Author

@MRabenda updated

@MRabenda
Copy link
Collaborator

  1. Please remove PNG from PR
  2. Your SVG has ~ 800kb regular one should have < 10 - can you improve it?

@ShailChoksi
Copy link
Contributor Author

  1. Please remove PNG from PR
  2. Your SVG has ~ 800kb regular one should have < 10 - can you improve it?
  1. Done
  2. I am not too familiar with SVGs so I am not able to get it much smaller before starting to lose details on the image. I cut it down to about 50% of the original.

@MRabenda
Copy link
Collaborator

From what I can see on Etherescan and Coinmarket cap Quid Ika has a different icon that this gray used here

@ShailChoksi
Copy link
Contributor Author

From what I can see on Etherescan and Coinmarket cap Quid Ika has a different icon that this gray used here

We have been rebranding. It takes time for CMC and Etherscan to update. Our Telegram, Discord and Dextools all have the new symbol/logo.

@ShailChoksi
Copy link
Contributor Author

@MRabenda let me know if you need more info or need me to prove that this is the new logo for the token

@ShailChoksi
Copy link
Contributor Author

Bump @MRabenda

@ShailChoksi
Copy link
Contributor Author

@MRabenda bump?

@MRabenda MRabenda merged commit 2b9473b into MetaMask:master Aug 11, 2022
@ShailChoksi ShailChoksi deleted the quidika branch September 21, 2022 18:33
@ShailChoksi
Copy link
Contributor Author

How long does it take for this to show up in the app?

@ShailChoksi ShailChoksi mentioned this pull request Sep 21, 2022
Closed
@MRabenda
Copy link
Collaborator

@ShailChoksi - QUID token has 18 or 9 decimals https://etherscan.io/address/0x9d38f670d15c14716be1f109a4f453e966a2b6d4#readContract ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MRabenda MRabenda MRabenda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShailChoksi @MRabenda