This repository has been archived by the owner on May 21, 2021. It is now read-only.
Validate new version #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
changelog-updating
branch
from
af9b7c6 to
56af347
Compare
Merged
rekmarks
force-pushed
the
validate-new-version
branch
from
a033637 to
38d3eef
Compare
rekmarks
force-pushed
the
validate-new-version
branch
from
38d3eef to
9627e61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validates the new version after getting all git tags and computing it from the action inputs. Previously, we only validated that the inputs were formatted correctly, but we weren't checking whether the new version was greater than the previous/current version or whether a tag already existed for the new version. While here, we also fix up some mocks in
update.test.ts.Kudos to @Gudahtt for reminding me that this is a good idea by implementing some of it in MetaMask/auto-changelog.