Skip to content
This repository has been archived by the owner on May 21, 2021. It is now read-only.

Add changelog updating #23

Merged
merged 6 commits into from
May 12, 2021
Merged

Add changelog updating #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb9c48a
Add changelog updating
rekmarks May 9, 2021
56af347
100% test coverage
rekmarks May 9, 2021
114ac24
Minor type fixup
rekmarks May 11, 2021
e14ae66
Fix a docstring
rekmarks May 11, 2021
b5096e0
Use path.sep
rekmarks May 12, 2021
19c3a07
Use path.join everywhere
rekmarks May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@ module.exports = {
'@typescript-eslint/no-shadow': ['error', { builtinGlobals: true }],
},
},
{
files: ['**/*.d.ts'],
rules: {
'import/unambiguous': 'off',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why disable this? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, on type definitions!? How does this rule apply to those 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I've looked into this, but I am still confused. No update. Welp.

I'm OK to let this slide for now but I still suspect we're doing something wrong.

Copy link
Member Author

@rekmarks rekmarks May 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense given the documentation of import/unambiguous: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/unambiguous.md

And indeed, using parserOptions: { sourceType: 'script' } } in the override works equally well. Maybe we prefer that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure 🤔 I'm curious which part of the docs indicate that this makes sense 😅 That is, it's not clear to me that a type definition is a module or a script. I don't know which fits better, if either. I was hoping that the TypeScript ESLint module would make some sense from this, but no such luck.

Given my limited understanding at the moment, turning it off seems like the most sensible approach.

},
},
{
files: ['**/*.test.js', '**/*.test.ts'],
extends: ['@metamask/eslint-config-jest'],
Expand Down
Loading