Fix readJsonObjectFile test

MetaMask · May 12, 2021 · 86ec0ec · 86ec0ec
1 parent aceedd7
commit 86ec0ec
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/utils.test.ts b/src/utils.test.ts
@@ -120,18 +120,15 @@ describe('readJsonObjectFile', () => {
 
   it('throws an error if the file parses to a falsy value', async () => {
     const path = 'arbitrary/path';
-
-    jest
-      .spyOn(fs.promises, 'readFile')
-      .mockImplementationOnce(async () => 'null')
-      .mockImplementationOnce(async () => '[]')
-      .mockImplementationOnce(async () => 'foobar')
-      .mockImplementationOnce(async () => 'true')
-      .mockImplementationOnce(async () => 'false');
-
-    await expect(readJsonObjectFile(path)).rejects.toThrow(
-      /non-object value\.$/u,
-    );
+    const readFileMock = jest.spyOn(fs.promises, 'readFile');
+    const badJsonValues = ['null', '[]', '"foobar"', 'true', 'false', '2'];
+
+    for (const badValue of badJsonValues) {
+      readFileMock.mockImplementationOnce(async () => badValue);
+      await expect(readJsonObjectFile(path)).rejects.toThrow(
+        /non-object value\.$/u,
+      );
+    }
   });
 });