Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump ts-bridge to 0.6.3 (fix some un-exported types) #214

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Feb 19, 2025

This PR fixes the type issue in @metamask/eth-simple-keyring where the TypedTransaction is not being exported.

Error:

TypeError: Cannot destructure property 'TypedTransaction' of '_ethereumjs_tx__WEBPACK_IMPORTED_MODULE_0___default(...)' as it is undefined.
    at ./node_modules/@metamask/eth-simple-keyring/dist/simple-keyring.mjs (http://localhost:6006/vendors-node_modules_metamask_keyring-controller_dist_KeyringController_mjs.iframe.bundle.js:7880:9)`

@montelaidev
Copy link
Contributor Author

@metamaskbot publish-preview

Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ts-bridge/[email protected] 🔁 npm/@ts-bridge/[email protected] None 0 196 kB mrten

View full report↗︎

Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/keyring-api": "17.1.0-157b637",
  "@metamask-previews/eth-hd-keyring": "10.0.0-157b637",
  "@metamask-previews/eth-ledger-bridge-keyring": "8.0.4-157b637",
  "@metamask-previews/eth-simple-keyring": "8.1.0-157b637",
  "@metamask-previews/eth-trezor-keyring": "6.1.0-157b637",
  "@metamask-previews/keyring-internal-api": "4.0.2-157b637",
  "@metamask-previews/keyring-internal-snap-client": "4.0.0-157b637",
  "@metamask-previews/eth-snap-keyring": "10.0.0-157b637",
  "@metamask-previews/keyring-snap-client": "4.0.0-157b637",
  "@metamask-previews/keyring-snap-sdk": "3.0.0-157b637",
  "@metamask-previews/keyring-utils": "2.1.1-157b637"
}

@montelaidev montelaidev changed the title fix(dep): bump ts-bridge to 0.6.3 fix(deps): bump ts-bridge to 0.6.3 Feb 19, 2025
@montelaidev montelaidev changed the title fix(deps): bump ts-bridge to 0.6.3 fix: bump ts-bridge to 0.6.3 Feb 19, 2025
@montelaidev montelaidev marked this pull request as ready for review February 19, 2025 09:31
@montelaidev montelaidev requested a review from a team as a code owner February 19, 2025 09:31
@montelaidev montelaidev added this pull request to the merge queue Feb 19, 2025
@ccharly ccharly removed this pull request from the merge queue due to a manual request Feb 19, 2025
@montelaidev montelaidev added this pull request to the merge queue Feb 19, 2025
@ccharly ccharly changed the title fix: bump ts-bridge to 0.6.3 build: bump ts-bridge to 0.6.3 Feb 19, 2025
@ccharly ccharly changed the title build: bump ts-bridge to 0.6.3 build: bump ts-bridge to 0.6.3 (fix some un-exported types) Feb 19, 2025
@ccharly ccharly removed this pull request from the merge queue due to a manual request Feb 19, 2025
@ccharly ccharly added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 2c28eb9 Feb 19, 2025
34 of 36 checks passed
@ccharly ccharly deleted the bump/ts-bridge-to-0.6.3 branch February 19, 2025 09:52
ccharly pushed a commit that referenced this pull request Feb 20, 2025
This PR fixes the type issue in `@metamask/eth-simple-keyring` where the
TypedTransaction is not being exported.

Error:
```
TypeError: Cannot destructure property 'TypedTransaction' of '_ethereumjs_tx__WEBPACK_IMPORTED_MODULE_0___default(...)' as it is undefined.
    at ./node_modules/@metamask/eth-simple-keyring/dist/simple-keyring.mjs (http://localhost:6006/vendors-node_modules_metamask_keyring-controller_dist_KeyringController_mjs.iframe.bundle.js:7880:9)`
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants