Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change root into Yarn project with workspace #160

Merged
merged 9 commits into from
Feb 24, 2025
Merged

Change root into Yarn project with workspace #160

merged 9 commits into from
Feb 24, 2025

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 12, 2025

actions/setup-node is failing because it can't find the nested yarn.lock. I've refactored the repository to have a Yarn project at the root instead, where tools/validate is a workspace inside of it. This should solve the following error in CI: https://github.com/MetaMask/SIPs/actions/runs/13285032176/job/37091737245

@socket-security Socket Security
Copy link

socket-security bot commented Feb 12, 2025 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] None 0 0 B
npm/@lavamoat/[email protected] None 0 0 B
npm/@lavamoat/[email protected] None 0 3.53 kB lmbot
npm/@npmcli/[email protected] environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 26.5 kB lukekarrys
npm/@npmcli/[email protected] environment, filesystem 0 23 kB npm-cli-ops
npm/@npmcli/[email protected] filesystem 0 1.87 kB lukekarrys
npm/@npmcli/[email protected] filesystem 0 39.5 kB npm-cli-ops
npm/@npmcli/[email protected] environment, shell 0 12.2 kB npm-cli-ops
npm/@npmcli/[email protected] environment 0 18.3 kB npm-cli-ops
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 2.76 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 1.68 MB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 8.54 kB types
npm/@types/[email protected] 🔁 npm/@types/[email protected] None +1 69.1 kB types
npm/[email protected] None 0 4.83 kB lukekarrys
npm/[email protected] network 0 31.5 kB tootallnate
npm/[email protected] None 0 6.69 kB sindresorhus
npm/[email protected] filesystem +1 24.2 kB npm-cli-ops
npm/[email protected] filesystem +1 78.1 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None 0 44.2 kB sindresorhus
npm/[email protected] filesystem 0 5.75 kB isaacs
npm/[email protected] None 0 5.51 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None +1 37.5 kB oss-bot
npm/[email protected] filesystem 0 12.2 kB npm-cli-ops
npm/[email protected] environment, filesystem, shell +2 37 kB satazor
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 7.12 kB andris
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 12.3 kB achingbrain
npm/[email protected] None 0 55.2 kB aboissinot, agong-coveo, coveo-organization, ...13 more
npm/[email protected] shell 0 69 kB isaacs
npm/[email protected] filesystem 0 14.1 kB isaacs
npm/[email protected] None 0 31.4 kB ljharb
npm/[email protected] environment, filesystem 0 32.5 kB isaacs
npm/[email protected] None 0 8.77 kB ljharb
npm/[email protected] None 0 26.6 kB npm-cli-ops
npm/[email protected] None 0 35.9 kB kornel
npm/[email protected] network 0 23.3 kB tootallnate
npm/[email protected] network Transitive: environment +1 78 kB tootallnate
npm/[email protected] None 0 349 kB ashtuchkin
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] None 0 4.4 kB sindresorhus
npm/[email protected] None 0 12.1 kB npm-cli-ops
npm/[email protected] None 0 177 kB beaugunderson
npm/[email protected] None 0 33.5 kB ljharb
npm/[email protected] None 0 2.94 kB watson
npm/[email protected] environment, filesystem 0 43 kB isaacs
npm/[email protected] environment 0 297 kB isaacs
npm/[email protected] None 0 46.9 kB andyperlitch
npm/[email protected] None 0 9.94 kB npm-cli-ops
npm/[email protected] None 0 804 kB isaacs
npm/[email protected] network +1 339 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] environment 0 435 kB isaacs
npm/[email protected] None 0 4.96 kB isaacs
npm/[email protected] environment, network +1 64.2 kB npm-cli-ops
npm/[email protected] None +1 51.9 kB isaacs
npm/[email protected] None 0 7 kB isaacs
npm/[email protected] None 0 124 kB isaacs
npm/[email protected] environment, filesystem 0 19.1 kB isaacs
npm/[email protected] None 0 6.72 kB styfle
npm/[email protected] None 0 28.6 kB blakeembrey
npm/[email protected] environment, shell +3 2.44 MB nodejs-foundation
npm/[email protected] None 0 26.2 kB npm-cli-ops
npm/[email protected] None 0 28.2 kB npm-cli-ops
npm/[email protected] None 0 6.21 kB npm-cli-ops
npm/[email protected] None 0 19.2 kB npm-cli-ops
npm/[email protected] None 0 16.5 kB npm-cli-ops
npm/[email protected] None 0 8.69 kB sindresorhus
npm/[email protected] None 0 36.5 kB isaacs
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] None 0 4.51 kB jbgutierrez
npm/[email protected] filesystem 0 535 kB isaacs
npm/[email protected] None 0 3.04 kB iarna
npm/[email protected] None 0 15.6 kB achingbrain
npm/[email protected] filesystem 0 5.16 kB lukekarrys
npm/[email protected] 🔁 npm/[email protected] None +3 42.6 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +4 55.7 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +5 73.7 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +3 42.7 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +2 30.4 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +2 30.3 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +5 104 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +2 30.4 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +35 1.58 MB wooorm
npm/[email protected] environment, filesystem 0 145 kB ljharb
npm/[email protected] None 0 32.2 kB tim-kos
npm/[email protected] None 0 42.3 kB chalker
npm/[email protected] None 0 2.56 kB kevva
npm/[email protected] None 0 2.83 kB sindresorhus
npm/[email protected] None 0 77 kB isaacs
npm/[email protected] 🔁 npm/[email protected] Transitive: filesystem +2 976 kB steveukx
npm/[email protected] None 0 138 kB joshglazebrook
npm/[email protected] network 0 25.5 kB tootallnate
npm/[email protected] None 0 156 kB joshglazebrook
npm/[email protected] None 0 23.4 kB kemitchell
npm/[email protected] None 0 3.47 kB kemitchell
npm/[email protected] None 0 11.8 kB kemitchell
npm/[email protected] None 0 12.9 kB kemitchell, shinnn
npm/[email protected] None 0 39.9 kB alexei
npm/[email protected] None 0 38.7 kB npm-cli-ops
npm/[email protected] None 0 0 B
npm/[email protected] None 0 0 B
npm/[email protected] 🔁 npm/[email protected] None 0 414 kB ianstormtaylor
npm/[email protected] None 0 9.18 kB ljharb
npm/[email protected] environment, filesystem +1 236 kB isaacs
npm/[email protected] 🔁 npm/[email protected] None +1 30.6 kB wooorm
npm/[email protected] None 0 400 kB sindresorhus
npm/[email protected] 🔁 npm/[email protected] None +1 34.2 kB wooorm
npm/[email protected] None 0 3.41 kB lukekarrys
npm/[email protected] None 0 2.58 kB lukekarrys
npm/[email protected] 🔁 npm/[email protected] None +4 147 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +2 80.4 kB wooorm
npm/[email protected] None 0 16.6 kB kemitchell
npm/[email protected] unsafe 0 7.77 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None 0 13.5 kB wooorm
npm/[email protected] 🔁 npm/[email protected] None +3 105 kB wooorm
npm/[email protected] environment 0 7.5 kB npm-cli-ops
npm/[email protected] None 0 0 B
npm/[email protected] filesystem 0 12.2 kB npm-cli-ops
npm/[email protected] 🔁 npm/[email protected] None 0 681 kB eemeli
npm/[email protected] 🔁 npm/[email protected] None 0 128 kB oss-bot
npm/[email protected] 🔁 npm/[email protected] None 0 292 kB oss-bot

🚮 Removed packages: npm/@types/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Feb 12, 2025 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/@npmcli/[email protected], npm/[email protected], npm/[email protected], npm/@lavamoat/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Feb 12, 2025

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@npmcli/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

New author is ok.

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@npmcli/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/@npmcli/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

Network access expected.

@SocketSecurity ignore npm/@lavamoat/[email protected]

Install script expected.

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

Shell access expected.

@Mrtenz
Copy link
Member Author

Mrtenz commented Feb 12, 2025

@SocketSecurity ignore npm/[email protected]
@SocketSecurity ignore npm/[email protected]

New author ok.

@SocketSecurity ignore npm/[email protected]

Shell access expected.

@Mrtenz Mrtenz marked this pull request as ready for review February 12, 2025 13:00
@Mrtenz Mrtenz requested a review from a team as a code owner February 12, 2025 13:00
@Mrtenz Mrtenz merged commit 345ac1c into main Feb 24, 2025
2 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-workflow branch February 24, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david0xd david0xd david0xd approved these changes

@GuillaumeRx GuillaumeRx GuillaumeRx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mrtenz @david0xd @GuillaumeRx