Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIP-29 to allow null in the handlers return value #157

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Update SIP-29 to allow null in the handlers return value #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions SIPS/sip-29.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ title: Snap Assets API
status: Draft
author: Daniel Rocha (@danroc), Guillaume Roux (@GuillaumeRx)
created: 2024-12-05
updated: 2025-01-25
---

## Abstract
Expand Down Expand Up @@ -89,7 +90,7 @@ The type for an `onAssetsLookup` handler function’s return value is:

```typescript
type OnAssetsLookupResponse = {
assets: Record<Caip19AssetType, AssetMetadata>;
assets: Record<Caip19AssetType, AssetMetadata | null>;
};
```

Expand Down Expand Up @@ -140,7 +141,7 @@ type FromAsset = Conversion["from"];
type ToAsset = Conversion["to"];

type OnAssetsConversionResponse = {
conversionRates: Record<From, Record<To, AssetConversionRate>>;
conversionRates: Record<From, Record<To, AssetConversionRate | null>>;
};
```

Expand Down
Loading