Fix bug for the remove method of BinarySearchTree (aalhour#58)

MetSystem · Sep 6, 2018 · 76e46e1 · 76e46e1
1 parent eba4e2f
commit 76e46e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/DataStructures/Trees/AugmentedBinarySearchTree.cs b/DataStructures/Trees/AugmentedBinarySearchTree.cs
@@ -146,7 +146,7 @@ protected bool _remove(BSTRankedNode<T> node)
 
             if (node.ChildrenCount == 2) // if both children are present
             {
-                var successor = node.RightChild;
+                var successor = _findNextLarger(node);
                 node.Value = successor.Value;
                 return (true && _remove(successor));
             }

diff --git a/DataStructures/Trees/BinarySearchTree.cs b/DataStructures/Trees/BinarySearchTree.cs
@@ -77,6 +77,10 @@ protected virtual void _replaceNodeInParent(BSTNode<T> node, BSTNode<T> newNode
                 else
                     node.Parent.RightChild = newNode;
             }
+            else
+            {
+                Root = newNode;
+            }
 
             if (newNode != null)
                 newNode.Parent = node.Parent;
@@ -96,7 +100,7 @@ protected virtual bool _remove(BSTNode<T> node)
 
             if (node.ChildrenCount == 2) // if both children are present
             {
-                var successor = node.RightChild;
+                var successor = _findNextLarger(node);
                 node.Value = successor.Value;
                 return (true && _remove(successor));
             }