Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc remove: Address review and clear up confusing terminology in prerequisite.py #34

Closed
wants to merge 16 commits into from
Closed

cylc remove: Address review and clear up confusing terminology in prerequisite.py #34

wants to merge 16 commits into from

Conversation

MetRonnie
Copy link
Owner

@hjoliver I've Opened this as a side PR to bash out any terminology/docs debates and keep the main PR cylc#6472 uncluttered

@MetRonnie MetRonnie mentioned this pull request Nov 13, 2024
Merged
8 tasks
@MetRonnie
Copy link
Owner Author

Are we happy with these changes to be put into the main PR?

@hjoliver
Copy link

Almost happy - see my comment today, above, on "active tasks".

hjoliver
hjoliver approved these changes Nov 25, 2024
View reviewed changes
Copy link

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy now, thanks @MetRonnie

@MetRonnie
Copy link
Owner Author

Incorporated

@MetRonnie MetRonnie closed this Nov 28, 2024
@MetRonnie MetRonnie deleted the cylc-remove-2 branch November 28, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @hjoliver @oliver-sanders