-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rtf rich text #184
Rtf rich text #184
Conversation
enable proper matching of nested braces
unclear why github actions previously worked without this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks neat! Thanks for improving on the previous implementation.
I only added a few minor fixes for code and documentation style to keep things consistent. Also used @noRd
instead of @keyword internal
to avoid generating .Rd
files for internal functions, which is the existing convention in this package.
@elong0527 Any comments?
Thanks for the updates @nanxstats . |
Good question! styler can apply the general style guide but it is not aggressive (probably to be on the safe side). For example, it doesn't know if new lines should be added or removed, and if words are properly stylized under the context. In those cases, I just apply the more comprehensive guides from the original tidyverse style guide manually when appropriate. That is ok because I think clean code / code style should be decided by humans ultimately, although automated rules surely help reduce manual work. |
Looks great! Thanks a lot for handling the task. |
Thanks @nanxstats and @elong0527 |
@BrianLang This sounds like a excellent topic for an external blog post or vignette. It's super ✨visual✨ |
I've made the updates to remove dependencies and also resolved an issue with brace matching.
Previously nesting of braces mixing rtf_text code like
{.emph text{^\\dagger}}
would end up matching the wrong braces and producing unexpected rtf output. Now it correctly resolves pairs of braces with FILO.closes #112
closes #185