-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement find_libreoffice()
#92
Comments
I will take this generous offer :) The information below from CRAN maintainer might be helpful.
I fixed the issue in 0011490 by skipping a test |
FYI - LibreOffice 7.3 was released in August 2022, so this line is currently preventing the package from working. |
@nanxstats, how about we add |
@fb-elong I like the creativity. That seems an easy way out, but I'm not convinced it will generalize well. My reasoning: this is essentially getting/setting a global state. Making it localized (required or optional) might bring more issues than it solves. Let's use compiling this book as an example. If we set a hard-coded |
Got it. In preparing a newer version, would you be able to find a robust way to enable |
@fb-elong I'm quite sure there is no major technical challenges. I cannot promise a timeline though - it's not a trivial amount of work, not to mention the time spent on testing on ALL mainstream platforms. So we should not let this become a blocker for any releases plans. |
Closing this issue as 7.3 support has been added. We have also agreed that we may not need a high-effort solution for this internal function which does not provide the core functionality of the package. |
This is a further fix for #64.
The overarching goal is to add flexibility to set up the path via a function argument or environment variable instead of fully automatic discovery. Sometimes, this would require adding a one-liner user-land code to point to the correct path (say if libreoffice is installed into nonconventional locations) but would make the function generalized enough and exportable later.
There should be a new function called
find_libreoffice()
, called byr2r2f:::rtf_convert_format()
. Here is a design proposal forfind_libreoffice()
:The general logic and style for discovery should be similar to
rmarkdown::find_pandoc()
andrmarkdown::find_program()
.Fallback order
dir
orpath
argument allowing the path to be set at the function call levelR2RTF_LIBREOFFICE
that you can set globally outside of the function; the environment variablePATH
(need to check if this is actually used by standard libreoffice installations)Other details
Testing environments
@elong0527 you can assign this to me.
The text was updated successfully, but these errors were encountered: