Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camelcase test #46

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix: camelcase test #46

merged 1 commit into from
Jun 8, 2023

Conversation

pnadolny13
Copy link
Contributor

Closes #40

The merge_from_stage and copy_from_stage accept a schema argument that it uses to build a query that selects from the raw json files in the stage using the json keys. Since the staging data is raw, we needed to pass in the raw unconformed schema instead of the conformed schema. The conformed schema converted the camelcase Id column to lower case id, so the query it built was trying to select a key in the json file that didnt exist. The query has lowercase and the file has camelcase.

@pnadolny13 pnadolny13 changed the title chore: fix camelcase test fix: camelcase test Jun 8, 2023
@pnadolny13 pnadolny13 merged commit f2c51e9 into main Jun 8, 2023
@pnadolny13 pnadolny13 deleted the fix_camelcase_test branch June 8, 2023 16:34
@pnadolny13 pnadolny13 mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: default test TargetCamelcaseTest throws IntegrityError
2 participants