Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add data type mapping for UUID #365

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

kinghuang
Copy link
Contributor

@kinghuang kinghuang commented Jun 4, 2024

I have a custom tap/extractor that outputs UUID identifiers with a schema Property like the following.

from singer_sdk import typing as th

th.Property(
    "id",
    th.UUIDType,
)

I want to load the data into a PostgreSQL database with the id in a column with the UUID type. This PR maps the schema string type with format uuid to the PostgreSQL uuid type.

@kinghuang kinghuang changed the title Add data type mapping for UUID feat: Add data type mapping for UUID Jun 4, 2024
@visch
Copy link
Member

visch commented Jun 4, 2024

@kinghuang Thanks for the PR it looks great to me. Just running the tests now

@visch
Copy link
Member

visch commented Jun 4, 2024

Looks like the certs in the repo are out of date causing this failure. The tests on the non SSL tests are passing fine. Created #366 we can fix those later. Merging

@visch visch merged commit 1e59be2 into MeltanoLabs:main Jun 4, 2024
3 of 9 checks passed
@kinghuang
Copy link
Contributor Author

Thanks!

@kinghuang kinghuang deleted the uuid-type branch June 4, 2024 19:24
@kinghuang kinghuang restored the uuid-type branch June 4, 2024 19:24
@kinghuang kinghuang deleted the uuid-type branch June 4, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants