Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using native SQLAlchemy for all interactions with DB #64

Closed
visch opened this issue Jan 12, 2023 · 1 comment
Closed

Migrate to using native SQLAlchemy for all interactions with DB #64

visch opened this issue Jan 12, 2023 · 1 comment

Comments

@visch
Copy link
Member

visch commented Jan 12, 2023

To address #58 (comment)

We want to switch at least how we're calculating the table names in our sql queries. If we can't get this to work with SQLAlchemy relatively easily we'll make a class representing the Database and add seperate getters for sqlalchemy and direct database pulls to help with quotation (ie compiling sql)

Once we fix this we need to remove the xfail from the tests that are currently failing due to this

@visch
Copy link
Member Author

visch commented Jun 15, 2023

#138 closes this

@visch visch closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant