Retain and update Clan CASE #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoancient
requested review from
sixlettervariables,
NickAragua and
Windchild292
sixlettervariables
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MML removes Clan CASE from mechs when they are loaded, presumably to keep it from showing up in the installed equipment list. This causes an unforeseen side effect from some of my recent work on BV calculations in MM, assigning an explosive equipment penalty when there shouldn't be one. MM used to base the check on an assumption that all Clan mechs have CASE installed automatically, though the rules state that Clan CASE can be omitted to reduce cost. Though we don't support that at this point, the BV calculation implementation is ready for it.
To fix it I removed the line that removes Clan CASE on load, added Clan CASE to the equipment that gets filtered out of the equipment list, and added some code that installs it as necessary when explosive equipment is added to a location. Removing CASE when the last explosive equipment is removed is a more complex problem because it can shift equipment numbers and cause problems with machine gun arrays. This has no effect on BV or the way the unit is saved. It can have an effect on cost calculations, but those are already incorrect and I'm planning to tackle those after BV, post-stable.
Fixes #846