Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Introductory tech level also showing Standard equipment in non-VTL mode. #1698

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jan 19, 2025

While exploring our Equipment filtering code as part of #1696 , I found that we are incorrectly applying the "Introductory" tech level filter in such a way that it always shows up to Standard-level equipment instead.

The fix is to use an existing function in SimpleTechLevel to get the correct enum value from the Tech Level combobox, which prevents the exception that defaults to Standard tech level.

Testing:

Close #1696

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.13%. Comparing base (b844630) to head (a493832).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1698   +/-   ##
========================================
  Coverage      2.13%   2.13%           
  Complexity      209     209           
========================================
  Files           271     271           
  Lines         31380   31380           
  Branches       5341    5341           
========================================
  Hits            670     670           
  Misses        30553   30553           
  Partials        157     157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit 4dcf73d into MegaMek:master Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Availability Year doesn't seem to be enforced properly
2 participants