Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix claw modifier in RS #1652

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Fix claw modifier in RS #1652

merged 1 commit into from
Nov 5, 2024

Conversation

pavelbraginskiy
Copy link
Member

Fixes #1651.

Printing looks up the Club modifier for a Claw when writing out reference tables.

Since a Claw isn't a kind of Club, this got a wonky result.

This PR makes it use the correct +1 modifier.

@pavelbraginskiy pavelbraginskiy added Bug Record Sheets Record Sheets and PDF/Printing issue labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 2.16%. Comparing base (ac1c381) to head (51bc6fe).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1652      +/-   ##
===========================================
- Coverage      2.16%   2.16%   -0.01%     
  Complexity      209     209              
===========================================
  Files           268     268              
  Lines         30911   30917       +6     
  Branches       5286    5288       +2     
===========================================
  Hits            669     669              
- Misses        30085   30091       +6     
  Partials        157     157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 7d4e904 into MegaMek:master Nov 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Record Sheets Record Sheets and PDF/Printing issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BattleMech Claws incorrectly show -1 target modifier on record sheets instead of +1
2 participants