Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving a MUL file from the queue-to-print dialog. #1595

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

pavelbraginskiy
Copy link
Member

Closes #1592.

In addition to letting you reorder the units in a MUL file, this also allows you to make a MUL file directly in MML, without involving MM, although you'll still need to involve MM to set pilot data or wire C3.

This PR also enables you to add units from cache when printing from a MUL file to add additional units to it, but the additional units won't have pilot data.

Eventually this dialog should have a way to customize units directly, but that's a more long-term goal.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.65%. Comparing base (126e393) to head (91bb560).
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1595      +/-   ##
===========================================
- Coverage      0.65%   0.65%   -0.01%     
  Complexity       64      64              
===========================================
  Files           266     266              
  Lines         30523   30545      +22     
  Branches       5203    5206       +3     
===========================================
  Hits            201     201              
- Misses        30282   30304      +22     
  Partials         40      40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Certainly I prefer re-using existing code in a simple and clear fashion over refactoring all the GUI stuff!

@HammerGS
Copy link
Member

Thank you for this!

@HammerGS HammerGS merged commit b1e5a23 into MegaMek:master Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save MUL file from inside MML
3 participants